Right now, we just JSON.stringify the arguments here:

duckdb-wasm/packages/duckdb-wasm/src/bindings/bindings_base.ts

Lines 197 to 210 in ffa9210

    
           public runPrepared(conn: number, statement: number, params: any[]): Uint8Array { 
        
               const [s, d, n] = callSRet( 
        
                   this.mod, 
        
                   'duckdb_web_prepared_run', 
        
                   ['number', 'number', 'string'], 
        
                   [conn, statement, JSON.stringify(params)], 
        
               ); 
        
               if (s !== StatusCode.SUCCESS) { 
        
                   throw new Error(readString(this.mod, d, n)); 
        
               } 
        
               const res = copyBuffer(this.mod, d, n); 
        
               dropResponseBuffers(this.mod); 
        
               return res; 
        
           }

and then unpack them here:

duckdb-wasm/lib/src/webdb.cc

Lines 219 to 242 in ffa9210

    
           rapidjson::Document args_doc; 
        
           rapidjson::ParseResult ok = args_doc.Parse(args_json.begin(), args_json.size()); 
        
           if (!ok) return arrow::Status{arrow::StatusCode::Invalid, rapidjson::GetParseError_En(ok.Code())}; 
        
           if (!args_doc.IsArray()) return arrow::Status{arrow::StatusCode::Invalid, "Arguments must be given as array"}; 
        
           std::vector<duckdb::Value> values; 
        
           size_t index = 0; 
        
           for (const auto& v : args_doc.GetArray()) { 
        
               if (v.IsLosslessDouble()) 
        
                   values.emplace_back(v.GetDouble()); 
        
               else if (v.IsString()) 
        
                   values.emplace_back(v.GetString()); 
        
               else if (v.IsNull()) 
        
                   values.emplace_back(nullptr); 
        
               else if (v.IsBool()) 
        
                   values.emplace_back(v.GetBool()); 
        
               else 
        
                   return arrow::Status{arrow::StatusCode::Invalid, 
        
                                        "Invalid column type encountered for argument " + std::to_string(index)}; 
        
               ++index; 
        
           } 
        
           auto result = stmt->second->Execute(values); 
        
           if (!result->success) return arrow::Status{arrow::StatusCode::ExecutionError, move(result->error)};

We probably just need to extend rapidjson::Document -> std::vector<duckdb::Value>.

	public runPrepared(conn: number, statement: number, params: any[]): Uint8Array {
	const [s, d, n] = callSRet(
	this.mod,
	'duckdb_web_prepared_run',
	['number', 'number', 'string'],
	[conn, statement, JSON.stringify(params)],
	);
	if (s !== StatusCode.SUCCESS) {
	throw new Error(readString(this.mod, d, n));
	}
	const res = copyBuffer(this.mod, d, n);
	dropResponseBuffers(this.mod);
	return res;
	}

	rapidjson::Document args_doc;
	rapidjson::ParseResult ok = args_doc.Parse(args_json.begin(), args_json.size());
	if (!ok) return arrow::Status{arrow::StatusCode::Invalid, rapidjson::GetParseError_En(ok.Code())};
	if (!args_doc.IsArray()) return arrow::Status{arrow::StatusCode::Invalid, "Arguments must be given as array"};

	std::vector<duckdb::Value> values;
	size_t index = 0;
	for (const auto& v : args_doc.GetArray()) {
	if (v.IsLosslessDouble())
	values.emplace_back(v.GetDouble());
	else if (v.IsString())
	values.emplace_back(v.GetString());
	else if (v.IsNull())
	values.emplace_back(nullptr);
	else if (v.IsBool())
	values.emplace_back(v.GetBool());
	else
	return arrow::Status{arrow::StatusCode::Invalid,
	"Invalid column type encountered for argument " + std::to_string(index)};
	++index;
	}

	auto result = stmt->second->Execute(values);
	if (!result->success) return arrow::Status{arrow::StatusCode::ExecutionError, move(result->error)};

Support array arguments in prepared statements #447

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions