Repository navigation
Update projection column by correct index in expression pushdown optimizers - #25431
Conversation
|
Thanks for the PR! Two (codex-assisted) comments:
|
|
Hi @lnkuiper. We can reason about (1) later but I don't want to introduce this change here to keep PR small and merge it faster. I've updated (2). |
|
Thanks! |
…mizers (duckdb#25431) This change fixes a bug in cast/scalar fn pushdown optimizers: whenever column was part of a Projection wrapping a Get, column's index within the projection may not have been the same as column's index within a Get. This change also fixes a bug in FinalizeScan where a thread without a `scan.job` (exhausted without scanning anything) got to run FinalizeScan which failed in MultiFileGetPartitionData after.
This change fixes a bug in cast/scalar fn pushdown optimizers: whenever column was part of a Projection wrapping a Get, column's index within the projection may not have been the same as column's index within a Get.
This change also fixes a bug in FinalizeScan where a thread without a
scan.job(exhausted without scanning anything) got to run FinalizeScan which failed in MultiFileGetPartitionData after.