Repository navigation
Only pushdown varchar if the arrow type is not a string view - #20165
Merged
Merged
Conversation
This was referenced Dec 12, 2025
lnkuiper
marked this pull request as ready for review
December 12, 2025 14:12
Member
|
Hmm, it does support for regular strings right? I think the current code will disable filter pushdown for varchar in general. |
pdet
self-requested a review
December 12, 2025 17:22
Member
Author
It returns: so non-stringview comparisons are still pushed down. |
Member
|
Ah, you are absolutely right, LGTM! |
evertlammerts
added a commit
to duckdb/duckdb-python
that referenced
this pull request
Dec 13, 2025
Ref: #187 Land only after duckdb/duckdb#20165 is merged Adds tests for arrow string and binary view filters
2 tasks done
github-actions Bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 31, 2025
Only pushdown varchar if the arrow type is not a string view (duckdb/duckdb#20165) Fix use-after-free in mode aggregate Combine function (duckdb/duckdb#20146) Fix minio nightly tests (duckdb/duckdb#20132)
github-actions Bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 31, 2025
Only pushdown varchar if the arrow type is not a string view (duckdb/duckdb#20165) Fix use-after-free in mode aggregate Combine function (duckdb/duckdb#20146) Fix minio nightly tests (duckdb/duckdb#20132) Co-authored-by: krlmlr <[email protected]>
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes duckdb/duckdb-python#187
The arrow table scan function relies on pyarrow for pushed down filters. Pyarrow does not support comparisons for view types yet, so we should not push filters down for those types.