Repository navigation
[Python] Read from file-like objects with read_json - #13040
Merged
Merged
Conversation
… well to fsspec, needs a better look and fixes
…eir MemoryFile wrapper, which fixes our close problems
duckdb-draftbot
marked this pull request as draft
July 18, 2024 08:40
Tishj
marked this pull request as ready for review
July 18, 2024 09:05
Member
Author
|
@Mytherin can you rerun https://github.com/duckdb/duckdb/actions/runs/9988686038/job/27605710521?pr=13040, there's an unrelated HTTP failure in the benchmark |
Member
|
Thanks! LGTM |
github-actions Bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jul 18, 2024
Merge pull request duckdb/duckdb#13040 from Tishj/python_read_json_filelike
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the functionality added by #6568 to the
read_jsonmethod.