Skip to content

Commit 6e4e339

Browse files
authored
Only pushdown varchar if the arrow type is not a string view (#20165)
Fixes duckdb/duckdb-python#187 The arrow table scan function relies on pyarrow for pushed down filters. Pyarrow does not support comparisons for view types yet, so we should not push filters down for those types.
2 parents 44b0575 + 85e4867 commit 6e4e339

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

‎src/function/table/arrow.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,10 +245,10 @@ static bool CanPushdown(const ArrowType &type) {
245245
case LogicalTypeId::UBIGINT:
246246
case LogicalTypeId::FLOAT:
247247
case LogicalTypeId::DOUBLE:
248-
case LogicalTypeId::VARCHAR:
249248
return true;
249+
case LogicalTypeId::VARCHAR:
250250
case LogicalTypeId::BLOB:
251-
// PyArrow doesn't support binary view filters yet
251+
// PyArrow doesn't support binary and string view filters yet
252252
return type.GetTypeInfo<ArrowStringInfo>().GetSizeType() != ArrowVariableSizeType::VIEW;
253253
case LogicalTypeId::DECIMAL: {
254254
switch (duck_type.InternalType()) {

0 commit comments

Comments
 (0)