Repository navigation
Fix truncated concatenated zstd response bodies - #470
Merged
ducaale merged 2 commits intoJul 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Responses using
Content-Encoding: zstdcan contain multiple concatenated frames. xh currently stops after the first one, silently truncating the response body. In #469 this cuts a JSON response at 65,536 bytes, leavingjqwith incomplete input.ruzstd::StreamingDecoderintentionally handles a single frame. This change keeps xh's lazy read behavior but drives a reusableFrameDecoderdirectly, advancing through standard and skippable frames without exposing an intermediate EOF. Incomplete following frames and truncated skippable payloads still surface as decode errors, and transport errors retain their existing context.Closes #469.