✅ Refresh NoRegression snapshots for stringMatching fix#7056
Merged
dubzzz merged 1 commit intoJun 7, 2026
Conversation
The pendingAggregatedValue reset fix changes the generated values back, so the stringMatching no-regression snapshots need refreshing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR targets the
faster-stringmatchingbranch (PR #7054). The latest commit on that branch resetspendingAggregatedValueinstringMatching.ts, which corrects the values produced byfc.stringMatchingfor a given seed. This refreshes thestringMatchingno-regression snapshots so the e2e suite passes on top of that fix.For end users this carries no behavioral change of its own — it only re-records the expected outputs of
fc.stringMatching. Notably, the fix brings the generated values back to their correct form: the odd trailing@.artifacts that the earlier speedup had introduced are gone, so the two affected snapshots (stringMatchingandstringMatching({maxLength:10})intest/e2e/NoRegression.spec.ts) revert to their pre-regression shape. No other no-regression snapshots changed, andNoRegressionStack.spec.tswas unaffected.Impact level: this is a test-only change (no library code), so it does not warrant a changeset of its own — it belongs with the perf PR it stacks on.
Scope is a single concern: regenerating the no-regression snapshots invalidated by the stringMatching fix. Snapshots were produced via
vitest -uand verified by re-runningtest/e2e/NoRegression.spec.ts(85 passing) andtest/e2e/NoRegressionStack.spec.ts(6 passing). These snapshots would have failed against the fix without this update — that mismatch is exactly what this PR resolves.Fixes #issue-number
Checklist
— Don't delete this checklist and make sure you do the following before opening the PR
pnpm run bumpor by following the instructions from the changeset bot🐛(vitest) Something...) when the change targets a package other thanfast-checkGenerated by Claude Code