Skip to content

✅ Refresh NoRegression snapshots for stringMatching fix#7056

Merged
dubzzz merged 1 commit into
faster-stringmatchingfrom
claude/noregression-snapshot-updates-hGF8P
Jun 7, 2026
Merged

✅ Refresh NoRegression snapshots for stringMatching fix#7056
dubzzz merged 1 commit into
faster-stringmatchingfrom
claude/noregression-snapshot-updates-hGF8P

Conversation

@dubzzz

@dubzzz dubzzz commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Description

AI-agent disclosure: this PR was authored by an automated agent (Claude Code) and has not been line-by-line reviewed by a human before submission.

This PR targets the faster-stringmatching branch (PR #7054). The latest commit on that branch resets pendingAggregatedValue in stringMatching.ts, which corrects the values produced by fc.stringMatching for a given seed. This refreshes the stringMatching no-regression snapshots so the e2e suite passes on top of that fix.

For end users this carries no behavioral change of its own — it only re-records the expected outputs of fc.stringMatching. Notably, the fix brings the generated values back to their correct form: the odd trailing @. artifacts that the earlier speedup had introduced are gone, so the two affected snapshots (stringMatching and stringMatching({maxLength:10}) in test/e2e/NoRegression.spec.ts) revert to their pre-regression shape. No other no-regression snapshots changed, and NoRegressionStack.spec.ts was unaffected.

Impact level: this is a test-only change (no library code), so it does not warrant a changeset of its own — it belongs with the perf PR it stacks on.

Scope is a single concern: regenerating the no-regression snapshots invalidated by the stringMatching fix. Snapshots were produced via vitest -u and verified by re-running test/e2e/NoRegression.spec.ts (85 passing) and test/e2e/NoRegressionStack.spec.ts (6 passing). These snapshots would have failed against the fix without this update — that mismatch is exactly what this PR resolves.

Fixes #issue-number

Checklist

Don't delete this checklist and make sure you do the following before opening the PR

  • I have a full understanding of every line in this PR — whether the code was hand-written, AI-generated, copied from external sources or produced by any other tool
  • I flagged the impact of my change (minor / patch / major) either by running pnpm run bump or by following the instructions from the changeset bot
  • I kept this PR focused on a single concern and did not bundle unrelated changes
  • I followed the gitmoji specification for the name of the PR, including the package scope (e.g. 🐛(vitest) Something...) when the change targets a package other than fast-check
  • I added relevant tests and they would have failed without my PR (when applicable)

Generated by Claude Code

The pendingAggregatedValue reset fix changes the generated values back,
so the stringMatching no-regression snapshots need refreshing.
@changeset-bot

changeset-bot Bot commented Jun 6, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8a9a3da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dubzzz
dubzzz merged commit 11af42c into faster-stringmatching Jun 7, 2026
2 checks passed
@dubzzz
dubzzz deleted the claude/noregression-snapshot-updates-hGF8P branch June 7, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants