♻️ Move generate logic to the Arbitrary for entityGraph#7006
Merged
Conversation
The logic of generate was spread in the custom arbitrary called `OnTheFlyLinksForEntityGraphArbitrary` and inside an helper. To ease the move towards no custom arbitrary we are moving back any generate code to the custom arbitrary.
🦋 Changeset detectedLatest commit: 084b1ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dubzzz
enabled auto-merge (squash)
May 19, 2026 19:31
@fast-check/ava
fast-check
@fast-check/jest
@fast-check/packaged
@fast-check/poisoning
@fast-check/vitest
@fast-check/worker
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7006 +/- ##
=======================================
Coverage 94.78% 94.79%
=======================================
Files 212 212
Lines 5832 5836 +4
Branches 1536 1535 -1
=======================================
+ Hits 5528 5532 +4
Misses 296 296
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic of generate was spread in the custom arbitrary called
OnTheFlyLinksForEntityGraphArbitraryand inside an helper. To ease the move towards no custom arbitrary we are moving back any generate code to the custom arbitrary.Description
Fixes #issue-number
Checklist
— Don't delete this checklist and make sure you do the following before opening the PR
pnpm run bumpor by following the instructions from the changeset bot🐛(vitest) Something...) when the change targets a package other thanfast-check