Skip to content

👷 Drop discussion creation on release publish#6975

Merged
dubzzz merged 3 commits into
mainfrom
claude/remove-release-discussions-KJ9pY
May 12, 2026
Merged

👷 Drop discussion creation on release publish#6975
dubzzz merged 3 commits into
mainfrom
claude/remove-release-discussions-KJ9pY

Conversation

@dubzzz

@dubzzz dubzzz commented May 12, 2026

Copy link
Copy Markdown
Owner

Removes the discussion_category_name input and discussions: write
permission from each publish job so releases no longer spawn an
announcement discussion.

Removes the discussion_category_name input and discussions: write
permission from each publish job so releases no longer spawn an
announcement discussion.
@changeset-bot

changeset-bot Bot commented May 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f98f1e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Discussion removal shifted setup-node line numbers in the publish jobs,
so update the ignore list in .github/zizmor.yml accordingly.
@pkg-pr-new

pkg-pr-new Bot commented May 12, 2026

Copy link
Copy Markdown
@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@6975

fast-check

npm i https://pkg.pr.new/fast-check@6975

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@6975

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@6975

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@6975

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@6975

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@6975

commit: f98f1e5

…-discussions-KJ9pY

# Conflicts:
#	.github/zizmor.yml
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedlodash@​4.18.1761008785100
Addedreact@​19.2.61001008497100
Addedreact-dom@​19.2.61001009298100

View full report

@socket-security

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: pnpm-lock.yamlnpm/[email protected]

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm entities is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: pnpm-lock.yamlnpm/[email protected]

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
Obfuscated code: npm markdown-it is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: pnpm-lock.yamlnpm/[email protected]

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@dubzzz
dubzzz enabled auto-merge (squash) May 12, 2026 20:44
@dubzzz
dubzzz merged commit 03d6bf9 into main May 12, 2026
49 checks passed
@dubzzz
dubzzz deleted the claude/remove-release-discussions-KJ9pY branch May 12, 2026 20:47
@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.78%. Comparing base (3c3985b) to head (f98f1e5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6975   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files         212      212           
  Lines        5832     5832           
  Branches     1536     1536           
=======================================
  Hits         5528     5528           
  Misses        296      296           
  Partials        8        8           
Flag Coverage Δ
tests 94.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dubzzz pushed a commit that referenced this pull request Jul 8, 2026
Rework the previous commit: instead of wiring the Bluesky announcement
into the publish pipeline as a reusable workflow, keep the standalone
'release: published' trigger and make it actually fire.

The trigger never fired because the 'Update GitHub Release' steps flip
the draft release to published with the default GITHUB_TOKEN, and GitHub
suppresses events created with that token from triggering workflows.
Passing a personal access token (RELEASE_PAT, contents read/write on
this repo) to softprops/action-gh-release lifts that suppression. Until
the secret is configured the expression falls back to github.token,
keeping the publish jobs working exactly as today.

Also drop the 'discussion_url' guard from the announce workflow: since
#6975 releases no longer create discussions, so it could never pass.

Co-Authored-By: Claude Fable 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01G7aBs4Xz7py7M2Mty82dwE
dubzzz pushed a commit that referenced this pull request Jul 8, 2026
Move the Bluesky announcement into the Create Release flow instead of
listening for 'release: published'. That event never fired: releases
are flipped from draft to published with the default GITHUB_TOKEN in
build-status.yml, and GitHub suppresses events created with that token
from triggering workflows (and the 'discussion_url' guard could never
pass anyway since #6975 dropped discussion creation).

Create Release runs on workflow_dispatch, so no token workaround is
needed there: the announce workflow becomes a reusable workflow_call
taking the tag, invoked right after the draft release is created and
the tag pushed, and skipped on dry runs. The post wording changes to
'on its way' since the npm package and release notes land a few
minutes later, once the publish pipeline flips the draft.

Co-Authored-By: Claude Fable 5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01G7aBs4Xz7py7M2Mty82dwE
dubzzz added a commit that referenced this pull request Jul 8, 2026
## Description

> AI-agent disclosure: this PR was authored by an automated agent
(Claude Code) and has not been line-by-line reviewed by a human before
submission.

Releases of fast-check and its sibling packages will now actually be
announced on Bluesky: the "Announce Release on Bluesky" workflow added
in #6959 has never fired once. The announcement now goes out when the
maintainer dispatches the Create Release workflow, right after the draft
release is created and the tag pushed, and the wording is adjusted to
match that timing — `🚀 New release on its way: fast-check v4.9.0`,
followed by a link to the release notes. The linked release page goes
live a few minutes later, once the publish pipeline flips the draft to
published. Dry runs of Create Release skip the post.

Why it never fired: the workflow listened to `release: published`, but
releases are flipped from draft to published by
`softprops/action-gh-release` inside the publish jobs using the default
`GITHUB_TOKEN`, and GitHub suppresses events created with that token
from triggering other workflows. Its `discussion_url != ''` guard was
dead too, since #6975 dropped discussion creation on releases.

Design: `announce-release-bluesky.yml` becomes a reusable
`workflow_call` taking the release tag, invoked from a new
`announce-release` job in `create-release.yml` — which now re-exports
the tag computed by its changelog-extract step as a job output.
Alternatives considered and rejected: publishing releases with a PAT so
`release: published` fires (a new long-lived secret to manage), or
wiring the announcement into the seven publish jobs of
`build-status.yml` (couples the social post to the publish pipeline).
Anchoring on the human-dispatched Create Release needs no new secret and
leaves `build-status.yml` untouched. The Bluesky secrets are declared
and passed explicitly to the called workflow rather than via `secrets:
inherit`, so only the three `BLUESKY_*` secrets are in its reach.

Impact level: patch, CI-only — no published package changes, hence no
changeset. The PR stays focused on a single concern: making the Bluesky
announcement flow fire. No automated tests were added: the change is
workflow glue around the existing, already smoke-tested
`post-bluesky.mjs`; YAML validity and the tag→URL/label mapping
(including slashed tags like `packaged/v0.7.1`) were verified locally.

<!-- Add any additional context here -->

## Checklist

— _Don't delete this checklist and make sure you do the following before
opening the PR_

- [ ] I have a full understanding of every line in this PR — whether the
code was hand-written, AI-generated, copied from external sources or
produced by any other tool
- [ ] I flagged the impact of my change (minor / patch / major) either
by running `pnpm run bump` or by following the instructions from the
changeset bot
- [ ] I kept this PR focused on a single concern and did not bundle
unrelated changes
- [ ] I followed the [gitmoji](https://gitmoji.dev/) specification for
the name of the PR, including the package scope (e.g. `🐛(vitest)
Something...`) when the change targets a package other than `fast-check`
- [ ] I added relevant tests and they would have failed without my PR
(when applicable)

<!-- PRs not checking all the boxes may take longer before being
reviewed -->
<!-- More about contributing at
https://github.com/dubzzz/fast-check/blob/main/CONTRIBUTING.md -->

---------

Co-authored-by: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants