Skip to content

👷 Drop caches on push for build package flow#6973

Merged
dubzzz merged 1 commit into
mainfrom
claude/remove-cache-push-flows-cpXlI
May 12, 2026
Merged

👷 Drop caches on push for build package flow#6973
dubzzz merged 1 commit into
mainfrom
claude/remove-cache-push-flows-cpXlI

Conversation

@dubzzz

@dubzzz dubzzz commented May 12, 2026

Copy link
Copy Markdown
Owner

Description

Push-triggered runs of the Build Status workflow (pushes to main, next-*_*_*, fix-v*) no longer reuse the pnpm cache when building production packages. The setup-node step in the production_packages job now disables its cache input on push events, so dependencies are installed fresh. Pull request runs are unchanged and still benefit from the pnpm cache.

The production packages produced by push flows are the ones that may end up being published. Skipping the cache there removes any chance of a stale or partially-populated cache silently influencing the built artifacts, at the cost of one uncached pnpm install per push build — an acceptable trade-off since publishable artifacts only flow through push events.

The conditional is expressed inline as cache: ${{ github.event_name == 'push' && '' || 'pnpm' }}. setup-node treats an empty cache input as "no cache" (its if (cache) guard short-circuits), so this is equivalent to omitting the input on push runs while keeping 'pnpm' everywhere else.

Scope is intentionally narrow: only the production_packages job is affected. The other jobs (format_lint, typecheck, test, …) keep using the cache so the rest of the matrix stays fast.

Checklist

Don't delete this checklist and make sure you do the following before opening the PR

  • I have a full understanding of every line in this PR — whether the code was hand-written, AI-generated, copied from external sources or produced by any other tool
  • I flagged the impact of my change (minor / patch / major) either by running pnpm run bump or by following the instructions from the changeset bot
  • I kept this PR focused on a single concern and did not bundle unrelated changes
  • I followed the gitmoji specification for the name of the PR, including the package scope (e.g. 🐛(vitest) Something...) when the change targets a package other than fast-check
  • I added relevant tests and they would have failed without my PR (when applicable)

Disable the setup-node pnpm cache in the production packages build
job when the workflow is triggered by a push event, so push flows
always install dependencies fresh without relying on the cache.
@changeset-bot

changeset-bot Bot commented May 12, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 52a3cdc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dubzzz dubzzz changed the title 👷 Drop pnpm cache on push for build package flow 👷 Drop caches on push for build package flow May 12, 2026
@pkg-pr-new

pkg-pr-new Bot commented May 12, 2026

Copy link
Copy Markdown
@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@6973

fast-check

npm i https://pkg.pr.new/fast-check@6973

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@6973

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@6973

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@6973

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@6973

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@6973

commit: 52a3cdc

@codecov

codecov Bot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.78%. Comparing base (c0da76f) to head (52a3cdc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6973   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files         212      212           
  Lines        5832     5832           
  Branches     1536     1536           
=======================================
  Hits         5528     5528           
  Misses        296      296           
  Partials        8        8           
Flag Coverage Δ
tests 94.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dubzzz
dubzzz merged commit 5d9f684 into main May 12, 2026
55 checks passed
@dubzzz
dubzzz deleted the claude/remove-cache-push-flows-cpXlI branch May 12, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants