👷 Grant discussions: write to release jobs#6932
Conversation
The release publish jobs use softprops/action-gh-release with discussion_category_name to link an Announcements discussion to each release, but the GITHUB_TOKEN was scoped to contents/id-token/attestations write only. With discussions permission missing, GitHub's release update endpoint surfaces the misleading error "Discussion could not be created. Make sure you passed a valid category name." (and the action retries exhausted), even though the category exists and the name is valid. This is also why no past release ever had a linked discussion regardless of the "Announcements" / "announcements" casing tried in #6877. Add discussions: write to every per-package publish job so the linked discussion can actually be created when finalizing the release.
|
|
👋 It looks like the PR template was not used for this pull request. Please edit the PR description to use the template, or close this PR and open a new one that uses it. The template includes:
Thank you for your contribution! 🙏 |
dubzzz
changed the title
discussions: write to release jobs
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
@claude fix zizmor job |
|
Claude finished @dubzzz's task in 2m 20s —— View job Todo List
SummaryZizmor's Adding Fix: updated the Note: I cannot edit files under |
Adding `discussions: write` to each release job shifted the setup-node line numbers by one per occurrence (602→603, 679→681, 756→759, 833→837, 910→915, 987→993, 1064→1071). Update the cache-poisoning ignore list in .github/zizmor.yml accordingly so the Workflow Security Audit job passes again. Co-authored-by: Nicolas DUBIEN <[email protected]>
@fast-check/ava
fast-check
@fast-check/jest
@fast-check/packaged
@fast-check/poisoning
@fast-check/vitest
@fast-check/worker
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6932 +/- ##
==========================================
+ Coverage 94.75% 94.78% +0.03%
==========================================
Files 211 212 +1
Lines 5778 5833 +55
Branches 1527 1535 +8
==========================================
+ Hits 5475 5529 +54
- Misses 295 296 +1
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
The release publish jobs use softprops/action-gh-release with
discussion_category_name to link an Announcements discussion to each
release, but the GITHUB_TOKEN was scoped to contents/id-token/attestations
write only. With discussions permission missing, GitHub's release update
endpoint surfaces the misleading error "Discussion could not be created.
Make sure you passed a valid category name." (and the action retries
exhausted), even though the category exists and the name is valid.
This is also why no past release ever had a linked discussion regardless
of the "Announcements" / "announcements" casing tried in #6877.
Add discussions: write to every per-package publish job so the linked
discussion can actually be created when finalizing the release.