Skip to content

🔧 Configure release workflow settings for announcements#6786

Merged
dubzzz merged 3 commits into
mainfrom
claude/fix-gh-release-upload-9bZTp
Mar 27, 2026
Merged

🔧 Configure release workflow settings for announcements#6786
dubzzz merged 3 commits into
mainfrom
claude/fix-gh-release-upload-9bZTp

Conversation

@dubzzz

@dubzzz dubzzz commented Mar 27, 2026

Copy link
Copy Markdown
Owner

Description

This PR updates the GitHub Actions release workflows to ensure consistent release configuration across all packages:

  • build-status.yml: Adds draft: false and discussion_category_name: Announcements to all 7 package release jobs (fast-check, ava, jest, packaged, poisoning, vitest, worker). These settings ensure releases are published immediately and discussions are created in the Announcements category.

  • create-release.yml: Changes the release creation workflow to use draft: true instead of draft: false, allowing releases to be reviewed before publication. Removes the discussion_category_name: Announcements setting from this workflow since draft releases don't create discussions.

The changes ensure that:

  1. Automated releases from build-status.yml are published immediately with announcement discussions
  2. Manual releases from create-release.yml are created as drafts for review before publication
  3. Configuration is consistent across all package release jobs

Checklist

  • I have a full understanding of every line in this PR
  • I kept this PR focused on a single concern (release workflow configuration)
  • I followed the gitmoji specification for the PR title

https://claude.ai/code/session_012pV1NsETLA79kvwjqrSYiz

@claude
🐛 Fix GitHub release asset upload by using draft releases
684c6cf 
GitHub now blocks asset uploads to published (non-draft) releases.
Create the release as a draft first, then publish it when uploading
assets in the build-status workflow. Move discussion_category_name
to the publish step since discussions can't be created on drafts.

https://claude.ai/code/session_012pV1NsETLA79kvwjqrSYiz
@changeset-bot

changeset-bot Bot commented Mar 27, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c9c2831

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

👋 It looks like the PR template was not used for this pull request.

Please edit the PR description to use the template, or close this PR and open a new one that uses it.
Not using the template may result in your change not being reviewed.

The template includes:

  • A Description section
  • A Checklist section with items to verify before submitting

Thank you for your contribution! 🙏

@pkg-pr-new

pkg-pr-new Bot commented Mar 27, 2026 •
edited
Loading

Copy link
Copy Markdown
@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@6786

fast-check

npm i https://pkg.pr.new/fast-check@6786

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@6786

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@6786

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@6786

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@6786

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@6786

commit: c9c2831

claude and others added 2 commits March 27, 2026 15:50
@socket-security

socket-security Bot commented Mar 27, 2026

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm vite is 91.0% likely obfuscated

Confidence: 0.91

Location: Package overview

From: pnpm-lock.yaml → npm/[email protected]

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@dubzzz
dubzzz enabled auto-merge (squash) March 27, 2026 15:54
@dubzzz
dubzzz merged commit 9a38a4c into main Mar 27, 2026
49 checks passed
@dubzzz
dubzzz deleted the claude/fix-gh-release-upload-9bZTp branch March 27, 2026 16:00
@codecov

codecov Bot commented Mar 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.52%. Comparing base (2c14656) to head (c9c2831).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6786   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files         210      210           
  Lines        5685     5685           
  Branches     1498     1499    +1     
=======================================
  Hits         5374     5374           
  Misses        298      298           
  Partials       13       13
Flag Coverage Δ
tests 94.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claude claude Bot mentioned this pull request Mar 27, 2026
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dubzzz @claude