Skip to content

👷 Fix check_publish status to be success on no error#6563

Merged
dubzzz merged 3 commits into
mainfrom
copilot/update-output-status-on-success
Feb 7, 2026
Merged

👷 Fix check_publish status to be success on no error#6563
dubzzz merged 3 commits into
mainfrom
copilot/update-output-status-on-success

Conversation

Copilot AI commented Feb 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Fix all check_publish_* jobs in .github/workflows/build-status.yml to output status: 'success' whenever the tag computation script runs without error
    • Added || true to grep commands to prevent no-match exit code from failing the step
    • Removed continue-on-error: true from all check_has_tag steps
    • Updated downstream if conditions to check tag != '' instead of status == 'success'
  • Update .github/zizmor.yml cache-poisoning ignore line numbers to match shifted lines
  • Validated YAML formatting
  • Verified zizmor passes locally (exit code 0, no findings)
  • Code review passed
Original prompt

I want the output status to be 'success' whenever we can execute the script computing tag without any error

outputs:
status: ${{steps.check_has_tag.outcome}}
tag: ${{steps.check_has_tag.outputs.tag}}
steps:

  • uses: actions/checkout@8e8c483 # v6.0.1
    with:
    persist-credentials: false
    fetch-depth: 0
  • id: check_has_tag
    name: Check if one tag matches the package
    run: echo "tag=$(git tag --points-at HEAD | grep '^packaged/v[0-9][0-9].[0-9][0-9].[0-9][0-9]*')" >> "$GITHUB_OUTPUT"
    continue-on-error: true
    put whatever you want (including unset) in case of error. make sure your code is properly formatted

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@changeset-bot

changeset-bot Bot commented Feb 7, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c2e6ab2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI changed the title [WIP] Update output status to success on script execution 👷 Fix check_publish status to be success on no error Feb 7, 2026
Copilot AI requested a review from dubzzz February 7, 2026 20:34
@dubzzz
dubzzz marked this pull request as ready for review February 7, 2026 20:38
@dubzzz
dubzzz enabled auto-merge (squash) February 7, 2026 20:38
@dubzzz
dubzzz disabled auto-merge February 7, 2026 20:38
@dubzzz

dubzzz commented Feb 7, 2026

Copy link
Copy Markdown
Owner

@copilot fix zizmor. It breaks on your change

@github-actions

github-actions Bot commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

👋 A preview of the new documentation is available at: http://6987a372ddbc2a240713b09b--dubzzz-fast-check.netlify.app

Copilot AI commented Feb 7, 2026

Copy link
Copy Markdown
Contributor Author

@copilot fix zizmor. It breaks on your change

Fixed in c2e6ab2. The cache-poisoning ignore line numbers in .github/zizmor.yml were stale after removing 7 continue-on-error: true lines from build-status.yml. Updated all 7 references to the correct shifted line numbers. Verified locally with zizmor --config .github/zizmor.yml . — passes cleanly.

Copilot AI requested a review from dubzzz February 7, 2026 20:41
@pkg-pr-new

pkg-pr-new Bot commented Feb 7, 2026

Copy link
Copy Markdown
@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@6563

fast-check

npm i https://pkg.pr.new/fast-check@6563

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@6563

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@6563

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@6563

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@6563

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@6563

commit: c2e6ab2

@github-actions

github-actions Bot commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

👋 A preview of the new documentation is available at: http://6987a865b936ef30e918ede3--dubzzz-fast-check.netlify.app

@codecov

codecov Bot commented Feb 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.85%. Comparing base (7016469) to head (c2e6ab2).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6563   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files         207      207           
  Lines        5581     5581           
  Branches     1468     1468           
=======================================
  Hits         5294     5294           
  Misses        274      274           
  Partials       13       13
Flag Coverage Δ
tests 94.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dubzzz
dubzzz merged commit 0449263 into main Feb 7, 2026
52 checks passed
@dubzzz
dubzzz deleted the copilot/update-output-status-on-success branch February 7, 2026 21:09
@ghost-of-high-heart ghost-of-high-heart Bot mentioned this pull request Apr 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dubzzz dubzzz dubzzz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@dubzzz dubzzz

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dubzzz