Skip to content

✅ Filter ESM-only packages from CommonJS mode checks#6507

Merged
dubzzz merged 2 commits into
mainfrom
copilot/filter-commonjs-packages
Jan 29, 2026
Merged

✅ Filter ESM-only packages from CommonJS mode checks#6507
dubzzz merged 2 commits into
mainfrom
copilot/filter-commonjs-packages

Conversation

Copilot AI commented Jan 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

ESM-only packages were conditionally excluded from CommonJS type checks only for TypeScript 5.0 and 5.7. Since these packages don't publish CommonJS exports at all, they should be excluded unconditionally.

Changes

  • Removed conditional logic from "Check in CommonJS mode" and "Check in CommonJS mode with NodeNext" steps
  • Always filter out ESM-only packages: @fast-check/ava, @fast-check/packaged, @fast-check/poisoning, @fast-check/vitest

Before:

- name: Check in CommonJS mode
  run: |
    if [ "${{ matrix.ts-version }}" = "5.0" ] || [ "${{ matrix.ts-version }}" = "5.7" ]; then
      pnpm --filter {./packages/**} --filter '!@fast-check/ava' ... exec "..."
    else
      pnpm --filter {./packages/**} ... exec "..."
    fi

After:

- name: Check in CommonJS mode
  run: pnpm --filter {./packages/**} --filter '!@fast-check/ava' --filter '!@fast-check/packaged' --filter '!@fast-check/poisoning' --filter '!@fast-check/vitest' --parallel -c exec "..."
Original prompt

filter out from the execution of "check in commonjs mode*" all packages that are only publishing esm

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@changeset-bot

changeset-bot Bot commented Jan 29, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d04779a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI changed the title [WIP] Filter out ESM-only packages from CommonJS execution 🔧 Filter ESM-only packages from CommonJS mode checks Jan 29, 2026
Copilot AI requested a review from dubzzz January 29, 2026 22:10
@dubzzz
dubzzz marked this pull request as ready for review January 29, 2026 22:14
@dubzzz dubzzz changed the title 🔧 Filter ESM-only packages from CommonJS mode checks ✅ Filter ESM-only packages from CommonJS mode checks Jan 29, 2026
@dubzzz
dubzzz enabled auto-merge (squash) January 29, 2026 22:15
@pkg-pr-new

pkg-pr-new Bot commented Jan 29, 2026

Copy link
Copy Markdown
@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@6507

fast-check

npm i https://pkg.pr.new/fast-check@6507

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@6507

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@6507

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@6507

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@6507

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@6507

commit: d04779a

@github-actions

github-actions Bot commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

👋 A preview of the new documentation is available at: http://697bdca426afc37689eec1da--dubzzz-fast-check.netlify.app

@dubzzz
dubzzz merged commit 031ea83 into main Jan 29, 2026
88 of 97 checks passed
@dubzzz
dubzzz deleted the copilot/filter-commonjs-packages branch January 29, 2026 22:45
@codecov

codecov Bot commented Jan 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.85%. Comparing base (791b23c) to head (d04779a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6507   +/-   ##
=======================================
  Coverage   94.85%   94.85%           
=======================================
  Files         207      207           
  Lines        5581     5581           
  Branches     1467     1468    +1     
=======================================
  Hits         5294     5294           
  Misses        274      274           
  Partials       13       13
Flag Coverage Δ
tests 94.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghost-of-high-heart ghost-of-high-heart Bot mentioned this pull request Apr 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dubzzz dubzzz dubzzz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@dubzzz dubzzz

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dubzzz