Skip to content

✅(worker) Bump e2e test timeouts from 1s to 5s#6386

Merged
dubzzz merged 2 commits into
mainfrom
copilot/bump-timeouts-in-e2e-tests
Dec 17, 2025
Merged

✅(worker) Bump e2e test timeouts from 1s to 5s#6386
dubzzz merged 2 commits into
mainfrom
copilot/bump-timeouts-in-e2e-tests

Conversation

Copilot AI commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

E2e tests were timing out with "Property timeout: exceeded limit of 1000 milliseconds" errors in CI, particularly in nonSerializableButSameData.spec.ts.

Changes

  • Increased assertTimeout from 1000ms to 5000ms across all 13 e2e test files in packages/worker/test/e2e/
  • Updated expected error message in blockEventLoop.spec.ts to match new 5000ms timeout value

The 5-second timeout provides adequate execution time for property-based tests under constrained CI environments.

Original prompt

bump the timeouts in e2e of worker to 5s, to drop these errors

FAIL @fast-check/worker test/e2e/nonSerializableButSameData.spec.ts�[2m > @fast-check/worker�[2m > should produce the same data in worker and main thread
AssertionError: expected 'Error: Property failed after 1 tests\…' to match />>>nonSerializableButSameDataProperty…/

  • Expected:
    />>>nonSerializableButSameDataProperty=(.*)<<</
  • Received:
    "Error: Property failed after 1 tests
    { seed: -1454768394, path: "0", endOnFailure: true }
    Counterexample: [Symbol.for("-962")]
    Shrunk 0 time(s)
    Got error: Property timeout: exceeded limit of 1000 milliseconds
    at Timeout. (D:/a/fast-check/fast-check/packages/fast-check/lib/check/property/TimeoutProperty.js:6:30)
    at listOnTimeout (node:internal/timers:605:17)
    at processTimers (node:internal/timers:541:7)

Hint: Enable verbose mode in order to have the list of all failing values encountered during the run"

�[2m❯ test/e2e/nonSerializableButSameData.spec.ts:�[2m36:27
34| const workerValueRegex = />>>nonSerializableButSameDataPrope…
35| expect(message).toMatch(mainValueRegex);
36| expect(message).toMatch(workerValueRegex);
| ^
37| const mainValue = mainValueRegex.exec(message)![1];
38| const workerValue = workerValueRegex.exec(message)![1];


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@changeset-bot

changeset-bot Bot commented Dec 17, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 39569cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI changed the title [WIP] Bump timeouts in e2e tests of worker to 5 seconds ⚡️(worker) Bump e2e test timeouts from 1s to 5s Dec 17, 2025
Copilot AI requested a review from dubzzz December 17, 2025 11:52
@dubzzz
dubzzz marked this pull request as ready for review December 17, 2025 11:55
Copilot AI review requested due to automatic review settings December 17, 2025 11:55
@dubzzz
dubzzz enabled auto-merge (squash) December 17, 2025 11:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR increases the timeout values for property-based tests in the worker package e2e test suite to prevent timeout failures in CI environments. The timeout increase from 1 second to 5 seconds addresses intermittent CI failures where tests were timing out before completion, particularly in nonSerializableButSameData.spec.ts.

Key Changes:

  • Updated assertTimeout constant from 1000ms to 5000ms across all e2e test files
  • Updated expected error message in blockEventLoop.spec.ts to reflect the new timeout value

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/worker/test/e2e/asyncThrow.spec.ts Updated assertTimeout from 1000 to 5000
packages/worker/test/e2e/blockEventLoop.spec.ts Updated assertTimeout from 1000 to 5000 and updated expected error message to match new timeout
packages/worker/test/e2e/concurrentAssert.spec.ts Updated assertTimeout from 1000 to 5000
packages/worker/test/e2e/failing.spec.ts Updated assertTimeout from 1000 to 5000
packages/worker/test/e2e/noWorker.spec.ts Updated assertTimeout from 1000 to 5000
packages/worker/test/e2e/nonSerializableButSameData.spec.ts Updated assertTimeout from 1000 to 5000
packages/worker/test/e2e/nonSerializableData.spec.ts Updated assertTimeout from 1000 to 5000
packages/worker/test/e2e/passing.spec.ts Updated assertTimeout from 1000 to 5000
packages/worker/test/e2e/predicateIsolation.spec.ts Updated assertTimeout from 1000 to 5000
packages/worker/test/e2e/propertyIsolation.spec.ts Updated assertTimeout from 1000 to 5000
packages/worker/test/e2e/supportPre.spec.ts Updated assertTimeout from 1000 to 5000
packages/worker/test/e2e/syncThrow.spec.ts Updated assertTimeout from 1000 to 5000
packages/worker/test/e2e/unregistered.spec.ts Updated assertTimeout from 1000 to 5000

@pkg-pr-new

pkg-pr-new Bot commented Dec 17, 2025

Copy link
Copy Markdown
@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@6386

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@6386

fast-check

npm i https://pkg.pr.new/fast-check@6386

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@6386

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@6386

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@6386

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@6386

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@6386

commit: 39569cb

@github-actions

Copy link
Copy Markdown
Contributor

@dubzzz dubzzz changed the title ⚡️(worker) Bump e2e test timeouts from 1s to 5s ✅(worker) Bump e2e test timeouts from 1s to 5s Dec 17, 2025
@dubzzz
dubzzz disabled auto-merge December 17, 2025 12:02
@dubzzz
dubzzz enabled auto-merge (squash) December 17, 2025 12:03
@dubzzz
dubzzz merged commit 3a48514 into main Dec 17, 2025
60 of 95 checks passed
@dubzzz
dubzzz deleted the copilot/bump-timeouts-in-e2e-tests branch December 17, 2025 12:04
@codecov

codecov Bot commented Dec 17, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.82%. Comparing base (b613932) to head (39569cb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6386   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files         206      206           
  Lines        5503     5503           
  Branches     1442     1443    +1     
=======================================
  Hits         5218     5218           
  Misses        272      272           
  Partials       13       13           
Flag Coverage Δ
tests 94.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI added a commit that referenced this pull request Dec 20, 2025
E2e tests were timing out with "Property timeout: exceeded limit of 1000
milliseconds" errors in CI, particularly in
`nonSerializableButSameData.spec.ts`.

## Changes

- Increased `assertTimeout` from 1000ms to 5000ms across all 13 e2e test
files in `packages/worker/test/e2e/`
- Updated expected error message in `blockEventLoop.spec.ts` to match
new 5000ms timeout value

The 5-second timeout provides adequate execution time for property-based
tests under constrained CI environments.

<!-- START COPILOT CODING AGENT SUFFIX -->



<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> bump the timeouts in e2e of worker to 5s, to drop these errors
> 
> 
> FAIL @fast-check/worker
test/e2e/nonSerializableButSameData.spec.ts�[2m > @fast-check/worker�[2m
> should produce the same data in worker and main thread
> AssertionError: expected 'Error: Property failed after 1 tests\…' to
match />>>nonSerializableButSameDataProperty…/
> 
> - Expected: 
> />>>nonSerializableButSameDataProperty=(.*)<<</
> 
> + Received: 
> "Error: Property failed after 1 tests
> { seed: -1454768394, path: \"0\", endOnFailure: true }
> Counterexample: [Symbol.for(\"-962\")]
> Shrunk 0 time(s)
> Got error: Property timeout: exceeded limit of 1000 milliseconds
> at Timeout.<anonymous>
(D:/a/fast-check/fast-check/packages/fast-check/lib/check/property/TimeoutProperty.js:6:30)
>     at listOnTimeout (node:internal/timers:605:17)
>     at processTimers (node:internal/timers:541:7)
> 
> Hint: Enable verbose mode in order to have the list of all failing
values encountered during the run"
> 
>  �[2m❯ test/e2e/nonSerializableButSameData.spec.ts:�[2m36:27
> 34| const workerValueRegex = />>>nonSerializableButSameDataPrope…
>      35|           expect(message).toMatch(mainValueRegex);
>      36|           expect(message).toMatch(workerValueRegex);
>        |                           ^
>      37|           const mainValue = mainValueRegex.exec(message)![1];
> 38| const workerValue = workerValueRegex.exec(message)![1];


</details>



<!-- START COPILOT CODING AGENT TIPS -->
---

💬 We'd love your input! Share your thoughts on Copilot coding agent in
our [2 minute survey](https://gh.io/copilot-coding-agent-survey).

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: dubzzz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants