✅(worker) Bump e2e test timeouts from 1s to 5s#6386
Conversation
|
Co-authored-by: dubzzz <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR increases the timeout values for property-based tests in the worker package e2e test suite to prevent timeout failures in CI environments. The timeout increase from 1 second to 5 seconds addresses intermittent CI failures where tests were timing out before completion, particularly in nonSerializableButSameData.spec.ts.
Key Changes:
- Updated
assertTimeoutconstant from 1000ms to 5000ms across all e2e test files - Updated expected error message in
blockEventLoop.spec.tsto reflect the new timeout value
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/worker/test/e2e/asyncThrow.spec.ts | Updated assertTimeout from 1000 to 5000 |
| packages/worker/test/e2e/blockEventLoop.spec.ts | Updated assertTimeout from 1000 to 5000 and updated expected error message to match new timeout |
| packages/worker/test/e2e/concurrentAssert.spec.ts | Updated assertTimeout from 1000 to 5000 |
| packages/worker/test/e2e/failing.spec.ts | Updated assertTimeout from 1000 to 5000 |
| packages/worker/test/e2e/noWorker.spec.ts | Updated assertTimeout from 1000 to 5000 |
| packages/worker/test/e2e/nonSerializableButSameData.spec.ts | Updated assertTimeout from 1000 to 5000 |
| packages/worker/test/e2e/nonSerializableData.spec.ts | Updated assertTimeout from 1000 to 5000 |
| packages/worker/test/e2e/passing.spec.ts | Updated assertTimeout from 1000 to 5000 |
| packages/worker/test/e2e/predicateIsolation.spec.ts | Updated assertTimeout from 1000 to 5000 |
| packages/worker/test/e2e/propertyIsolation.spec.ts | Updated assertTimeout from 1000 to 5000 |
| packages/worker/test/e2e/supportPre.spec.ts | Updated assertTimeout from 1000 to 5000 |
| packages/worker/test/e2e/syncThrow.spec.ts | Updated assertTimeout from 1000 to 5000 |
| packages/worker/test/e2e/unregistered.spec.ts | Updated assertTimeout from 1000 to 5000 |
@fast-check/ava
@fast-check/expect-type
fast-check
@fast-check/jest
@fast-check/packaged
@fast-check/poisoning
@fast-check/vitest
@fast-check/worker
commit: |
|
👋 A preview of the new documentation is available at: http://69429b1cef7d8c2f28e6ceb7--dubzzz-fast-check.netlify.app |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6386 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 206 206
Lines 5503 5503
Branches 1442 1443 +1
=======================================
Hits 5218 5218
Misses 272 272
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
E2e tests were timing out with "Property timeout: exceeded limit of 1000
milliseconds" errors in CI, particularly in
`nonSerializableButSameData.spec.ts`.
## Changes
- Increased `assertTimeout` from 1000ms to 5000ms across all 13 e2e test
files in `packages/worker/test/e2e/`
- Updated expected error message in `blockEventLoop.spec.ts` to match
new 5000ms timeout value
The 5-second timeout provides adequate execution time for property-based
tests under constrained CI environments.
<!-- START COPILOT CODING AGENT SUFFIX -->
<!-- START COPILOT ORIGINAL PROMPT -->
<details>
<summary>Original prompt</summary>
> bump the timeouts in e2e of worker to 5s, to drop these errors
>
>
> FAIL @fast-check/worker
test/e2e/nonSerializableButSameData.spec.ts�[2m > @fast-check/worker�[2m
> should produce the same data in worker and main thread
> AssertionError: expected 'Error: Property failed after 1 tests\…' to
match />>>nonSerializableButSameDataProperty…/
>
> - Expected:
> />>>nonSerializableButSameDataProperty=(.*)<<</
>
> + Received:
> "Error: Property failed after 1 tests
> { seed: -1454768394, path: \"0\", endOnFailure: true }
> Counterexample: [Symbol.for(\"-962\")]
> Shrunk 0 time(s)
> Got error: Property timeout: exceeded limit of 1000 milliseconds
> at Timeout.<anonymous>
(D:/a/fast-check/fast-check/packages/fast-check/lib/check/property/TimeoutProperty.js:6:30)
> at listOnTimeout (node:internal/timers:605:17)
> at processTimers (node:internal/timers:541:7)
>
> Hint: Enable verbose mode in order to have the list of all failing
values encountered during the run"
>
> �[2m❯ test/e2e/nonSerializableButSameData.spec.ts:�[2m36:27
> 34| const workerValueRegex = />>>nonSerializableButSameDataPrope…
> 35| expect(message).toMatch(mainValueRegex);
> 36| expect(message).toMatch(workerValueRegex);
> | ^
> 37| const mainValue = mainValueRegex.exec(message)![1];
> 38| const workerValue = workerValueRegex.exec(message)![1];
</details>
<!-- START COPILOT CODING AGENT TIPS -->
---
💬 We'd love your input! Share your thoughts on Copilot coding agent in
our [2 minute survey](https://gh.io/copilot-coding-agent-survey).
---------
Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: dubzzz <[email protected]>
E2e tests were timing out with "Property timeout: exceeded limit of 1000 milliseconds" errors in CI, particularly in
nonSerializableButSameData.spec.ts.Changes
assertTimeoutfrom 1000ms to 5000ms across all 13 e2e test files inpackages/worker/test/e2e/blockEventLoop.spec.tsto match new 5000ms timeout valueThe 5-second timeout provides adequate execution time for property-based tests under constrained CI environments.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.