Add circular dependencies script #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thothd
approved these changes
Apr 8, 2019
Member
Author
|
Since this thing has gone through bitcoin-review and is merely a backport without any change related to the build or the code itself I am merging this with one approval only. |
Member
|
Maybe it would be good to add a copyright header to the file. I know, it's taken as it is from upstream, but just to make clear where it's coming from and have the attribution clear. |
Member
Author
Will follow up on this with a separate pull. I did not expect this not to have a copyright header. At least the commit message attributes the original pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of bitcoin/bitcoin#13228
This is in 0.18, not in 0.17, so we won't get it automagically from merging with 0.17. It's just a script in contrib to detect circular dependencies.