Fix segmentation fault after unloading wallet #904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmihai
force-pushed
the
merge-bitcoin-0.17
branch
from
0e33a92 to
266eb80
Compare
Bitcoin 0.17 now allows us to unload (and re-load) wallets. This clashed with the `CWalletExtension::ManagePendingSlashings`, which was scheduled to run periodically every 10 seconds, and which tried to access the wallet, even though it could be unloaded by that moment. This commit saves a reference to the wallet during the execution of the task, to avoid a segfault. Further, it introduces a new type of benign exception, `task_unscheduled`, which interrupts the execution of the current task and does not reschedule it. Signed-off-by: Mihai Ciumeica <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitcoin 0.17 now allows us to unload (and re-load) wallets. This clashed
with the
CWalletExtension::ManagePendingSlashings, which was scheduledto run periodically every 10 seconds, and which tried to access the
wallet, even though it could be unloaded by that moment.
This commit saves a reference to the wallet during the execution of the
task, to avoid a segfault. Further, it introduces a new type of benign
exception,
task_unscheduled, which interrupts the execution of thecurrent task and does not reschedule it.