Skip to content

Fix compilation warning in UnitEInjector #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frolosofsky merged 1 commit into from
Apr 2, 2019
Merged

Fix compilation warning in UnitEInjector #876

frolosofsky merged 1 commit into from
Apr 2, 2019

Conversation

@frolosofsky
Copy link
Member

@frolosofsky frolosofsky commented Apr 2, 2019 •
edited
Loading

Fixes warning introduced by #870.

In file included from ./injector.h:17:
./injector_config.h:8:1: warning: 'UnitEInjectorConfiguration' defined as a struct here but previously declared as a class [-Wmismatched-tags]
struct UnitEInjectorConfiguration {
^
./finalization/state_db.h:24:1: note: did you mean struct here?
class UnitEInjectorConfiguration;
^~~~~
struct

@frolosofsky
Fix warning
920196c 
Signed-off-by: Stanislav Frolov <[email protected]>
@frolosofsky frolosofsky added the technical debt Cleaning up code which is there for historical reasons label Apr 2, 2019
@frolosofsky frolosofsky self-assigned this Apr 2, 2019
@frolosofsky frolosofsky requested review from a team and scravy April 2, 2019 07:02
@frolosofsky frolosofsky changed the title Fix warning Fix compilation warning in UnitEInjector Apr 2, 2019
Gnappuraz
Gnappuraz approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@Gnappuraz Gnappuraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 920196c

AM5800
AM5800 approved these changes Apr 2, 2019
View reviewed changes
Copy link
Member

@AM5800 AM5800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 920196c

@frolosofsky frolosofsky merged commit 8c5e35c into dtr-org:master Apr 2, 2019
@frolosofsky frolosofsky deleted the fix-warning branch April 2, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AM5800 AM5800 AM5800 approved these changes

@Gnappuraz Gnappuraz Gnappuraz approved these changes

@scravy scravy Awaiting requested review from scravy

Assignees

@frolosofsky frolosofsky

Labels

technical debt Cleaning up code which is there for historical reasons

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@frolosofsky @AM5800 @Gnappuraz