Fix p2p_sendheaders race #759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p2p_sendheaders has a race in part 1.3. part 1.2 sends a block to the node over the 'test_node' connection, but doesn't wait for an inv to be received on the 'inv_node' connection. If we get to part 1.3 before that inv has been received, then the subsequent call to check_last_inv_announcement could fail.
thothd
reviewed
Mar 10, 2019
Member
thothd
left a comment
thothd
left a comment
There was a problem hiding this comment.
Seems like the code is unchanged from Bitcoin Core, did you cherry pick it? since GitHub shows like you committed it ("newbery authored and dsaveliev committed")
Member
Author
|
Yes, exactly, this is a cherry-pick of bitcoin-core commit without any changes from my side |
scravy
approved these changes
Mar 11, 2019
Member
|
I'll merge-merge this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #586
This is a port of bitcoin/bitcoin#13522
There is a race between inv messages in p2p connection to the test node.
Test runs:
https://travis-ci.com/dsaveliev/unit-e/builds/103828612
https://travis-ci.com/dsaveliev/unit-e/builds/103830184