Use typed GetComponent #726
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stanislav Frolov <[email protected]>
frolosofsky
added
the
refactoring
Signed-off-by: Stanislav Frolov <[email protected]>
cmihai
reviewed
Mar 4, 2019
Member
Author
|
Closing in favor #721. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's an alternative approach to fix #618. The first one is #721.
Unlike #721 this change doesn't spread usage of NAME macro but relies on
m_componentstyped container. Also, adds a bit of test.Signed-off-by: Stanislav Frolov [email protected]