-
Notifications
You must be signed in to change notification settings - Fork 14
Use RenameThread to set proposer-thread name #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Julian Fleischer <[email protected]>
Signed-off-by: Julian Fleischer <[email protected]>
Ruteri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 982855c
Signed-off-by: Julian Fleischer <[email protected]>
|
@kostyantyn I updated the developer-notes, please re-review ( https://github.com/dtr-org/unit-e/pull/481/files#diff-e4de6d71249c78e229a61d6a03ac255aR242 ) |
2ca7b68 to
28f8989
Compare
Signed-off-by: Julian Fleischer <[email protected]>
28f8989 to
638285d
Compare
kostyantyn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 638285d
See in logs:
2019-01-25 15:13:57 unite-proposer [ proposing] Proposer thread started.
2019-01-25 15:13:59 unite-proposer [ proposing] Proposer thread stopping...
cmihai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 638285d
As discussed with @kostyantyn – should use
RenameThreadto name the proposer thread, just like all other threads are named too.Also discussed: Every thread should log when it starts and stops running – the proposer is already doing that:
RenameThreadis invoked before the log statement so that it prints the correct thread name in case you enabled that as per #257Signed-off-by: Julian Fleischer [email protected]