Skip to content

Conversation

@scravy
Copy link
Member

@scravy scravy commented Jan 25, 2019

As discussed with @kostyantyn – should use RenameThread to name the proposer thread, just like all other threads are named too.

Also discussed: Every thread should log when it starts and stops running – the proposer is already doing that:

  void Run() {
    RenameThread(THREAD_NAME);
    LogPrint(BCLog::PROPOSING, "Proposer thread started.\n");
    // ...
    LogPrint(BCLog::PROPOSING, "Proposer thread stopping...\n");
  }

RenameThread is invoked before the log statement so that it prints the correct thread name in case you enabled that as per #257

Signed-off-by: Julian Fleischer [email protected]

@scravy scravy added the technical debt Cleaning up code which is there for historical reasons label Jan 25, 2019
@scravy scravy added this to the 0.1 milestone Jan 25, 2019
@scravy scravy self-assigned this Jan 25, 2019
@kostyantyn
Copy link
Member

Copy link
Member

@Ruteri Ruteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 982855c

Signed-off-by: Julian Fleischer <[email protected]>
@scravy
Copy link
Member Author

scravy commented Jan 25, 2019

@scravy scravy force-pushed the proposer-thread-fixes branch from 2ca7b68 to 28f8989 Compare January 25, 2019 15:03
@scravy scravy force-pushed the proposer-thread-fixes branch from 28f8989 to 638285d Compare January 25, 2019 15:04
Copy link
Member

@kostyantyn kostyantyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 638285d

See in logs:

2019-01-25 15:13:57  unite-proposer [   proposing] Proposer thread started.
2019-01-25 15:13:59  unite-proposer [   proposing] Proposer thread stopping...

Copy link
Member

@cmihai cmihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 638285d

@scravy scravy merged commit f42533f into dtr-org:master Jan 25, 2019
@scravy scravy deleted the proposer-thread-fixes branch January 25, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

proposing technical debt Cleaning up code which is there for historical reasons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants