Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dtolnay/thiserror
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2.0.0
Choose a base ref
...
head repository: dtolnay/thiserror
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.0.1
Choose a head ref
  • 20 commits
  • 11 files changed
  • 1 contributor

Commits on Nov 8, 2024

  1. Add test of dynamically sized error type

        error[E0599]: the method `as_display` exists for reference `&str`, but its trait bounds were not satisfied
          --> tests/test_path.rs:26:9
           |
        26 | #[error("{tail}")]
           |         ^^^^^^^^ method cannot be called on `&str` due to unsatisfied trait bounds
           |
           = note: the following trait bounds were not satisfied:
                   `str: Sized`
                   which is required by `&str: AsDisplay<'_>`
    dtolnay committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8e8e273 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    24c04da View commit details
    Browse the repository at this point in the history
  3. Merge pull request #375 from dtolnay/unsized

    Support dynamically sized field in error
    dtolnay authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2f6bff3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1bb7e7a View commit details
    Browse the repository at this point in the history
  5. Merge pull request #376 from dtolnay/check

    Check invalid Named member references before producing MemberUnraw
    dtolnay authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    f728f12 View commit details
    Browse the repository at this point in the history
  6. Add test using generic type with multiple bounds

        error[E0277]: the trait bound `T: UpperHex` is not satisfied
           --> tests/test_generics.rs:179:13
            |
        178 |     #[derive(Error, Debug)]
            |              ----- in this derive macro expansion
        179 |     #[error("0x{thing:x} 0x{thing:X}")]
            |             ^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `UpperHex` is not implemented for `T`
            |
            = note: required for `&T` to implement `UpperHex`
        note: required by a bound in `core::fmt::rt::Argument::<'_>::new_upper_hex`
           --> $RUSTUP_HOME/toolchains/nightly-aarch64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/fmt/rt.rs:133:29
            |
        133 |     pub fn new_upper_hex<T: UpperHex>(x: &T) -> Argument<'_> {
            |                             ^^^^^^^^ required by this bound in `Argument::<'_>::new_upper_hex`
            = note: this error originates in the macro `$crate::format_args` which comes from the expansion of the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info)
    dtolnay committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    fb8d3a7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5948ee6 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #377 from dtolnay/bounds

    Support generic types that need multiple bounds
    dtolnay authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8e5c843 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    337df1d View commit details
    Browse the repository at this point in the history
  10. Merge pull request #378 from dtolnay/self

    Move recursion checking out of bindings
    dtolnay authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    17fa0d2 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    24e7f87 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    8a77dea View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    f4d5c2a View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    3ee0a4d View commit details
    Browse the repository at this point in the history
  15. Resolve let_and_return clippy lint

        warning: returning the result of a `let` binding from a block
          --> impl/src/fmt.rs:67:21
           |
        63 | /                     let member = match int.parse::<u32>() {
        64 | |                         Ok(index) => MemberUnraw::Unnamed(Index { index, span }),
        65 | |                         Err(_) => return Ok(()),
        66 | |                     };
           | |______________________- unnecessary `let` binding
        67 |                       member
           |                       ^^^^^^
           |
           = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
           = note: `-W clippy::let-and-return` implied by `-W clippy::all`
           = help: to override `-W clippy::all` add `#[allow(clippy::let_and_return)]`
        help: return the expression directly
           |
        63 ~
        64 ~                     match int.parse::<u32>() {
        65 +                         Ok(index) => MemberUnraw::Unnamed(Index { index, span }),
        66 +                         Err(_) => return Ok(()),
        67 +                     }
           |
    dtolnay committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    fb59da6 View commit details
    Browse the repository at this point in the history
  16. Merge pull request #379 from dtolnay/binding

    Emit rebinding only for interpolations that refer to a field
    dtolnay authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    5dfd2cc View commit details
    Browse the repository at this point in the history
  17. Add test that {:p} prints the right address

        thread 'test_pointer' panicked at tests/test_display.rs:265:5:
        assertion `left == right` failed
          left: "0x7fbbd7df10"
         right: "0x7fac000e30"
    dtolnay committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    46586dd View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    16f8dc1 View commit details
    Browse the repository at this point in the history
  19. Merge pull request #380 from dtolnay/var

    Print field's address instead of local's address for Pointer
    dtolnay authored Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8956be2 View commit details
    Browse the repository at this point in the history
  20. Release 2.0.1

    dtolnay committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    4066d53 View commit details
    Browse the repository at this point in the history
Loading