fix: use backslash for path on windows#50
Closed
wenym1 wants to merge 1 commit intodtolnay:masterfrom
Closed
Conversation
dtolnay
reviewed
May 14, 2024
Owner
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
Thanks for the PR!
As is, this change would break cross-compilation from non-Windows to Windows because target_os = "windows" would be true in that case but \ paths do not make sense on the non-Windows host. I put up #51 with an implementation that decides the path separator based on the host platform, rather than the target platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR tokio-rs/tokio#6558, I was trying to use
rustversion.But it fails the CI on windows-latest due to the following error.
This is because currently the version is loaded from a path with fixed
/as path separator, but on windows the path separator should be\.In this PR, we will change to use
\as path separator for windows.In a separate CI run that uses the commit patched from this PR, the test passes.