Skip to content

perf: reduce llvm-lines in runtime.rs #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dtolnay merged 1 commit into from
Nov 3, 2025
Merged

perf: reduce llvm-lines in runtime.rs #307

dtolnay merged 1 commit into from
Nov 3, 2025
+8 −7

Conversation

@dishmaker
Copy link
Contributor

@dishmaker dishmaker commented Nov 3, 2025

731 less llvm lines.

Before:

quote$ cargo llvm-lines --release | head -n 3
  Lines               Copies             Function name
  -----               ------             -------------
  8959                447                (TOTAL)

After:

quote$ cargo llvm-lines --release | head -n 3
  Lines               Copies             Function name
  -----               ------             -------------
  8228                403                (TOTAL)

dtolnay
dtolnay approved these changes Nov 3, 2025
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit eac3231 into dtolnay:master Nov 3, 2025
11 checks passed
jplatte
jplatte reviewed Nov 6, 2025
View reviewed changes
src/runtime.rs
pub fn parse_spanned(tokens: &mut TokenStream, span: Span, s: &str) {
let s: TokenStream = s.parse().expect("invalid token stream");
tokens.extend(s.into_iter().map(|t| respan_token_tree(t, span)));
for token in s.into_iter() {
Copy link

@jplatte jplatte Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .into_iter() call is redundant, no?

Copy link
Contributor Author

@dishmaker dishmaker Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed in e868345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

+1 more reviewer

@jplatte jplatte jplatte left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dishmaker @jplatte @dtolnay