Skip to content

perf: monomorphize TokenStreamExt::append_all on Iterator #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dtolnay merged 1 commit into from
Nov 3, 2025
Merged

perf: monomorphize TokenStreamExt::append_all on Iterator #306

dtolnay merged 1 commit into from
Nov 3, 2025
+9 −2

Conversation

@dishmaker
Copy link
Contributor

@dishmaker dishmaker commented Nov 3, 2025 •
edited
Loading

So this doesn't change llvm-lines in quote.

But syn uses append_all, so it is decresed by 187 lines

Before:

syn$ cargo llvm-lines --release --all-features | head -n 3
   Compiling quote v1.0.41 (../quote)
   Compiling syn v2.0.108 (./syn)
  Lines                 Copies              Function name
  -----                 ------              -------------
  221157                4748                (TOTAL)

After:

syn$ cargo llvm-lines --release --all-features | head -n 3
   Compiling quote v1.0.41 (../quote)
   Compiling syn v2.0.108 (./syn)
  Lines                 Copies              Function name
  -----                 ------              -------------
  220970                4726                (TOTAL)

@dtolnay dtolnay merged commit 801c6bd into dtolnay:master Nov 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnay dtolnay dtolnay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dishmaker @dtolnay