build: allow the cleanup step to be non-fatal#505
Merged
dtolnay merged 1 commit intodtolnay:masterfrom Aug 11, 2025
Merged
Conversation
davvid
force-pushed
the
ignore-cleanup
branch
2 times, most recently
from
a07d529 to
82aa3b7
Compare
dtolnay
requested changes
Aug 11, 2025
Owner
dtolnay
left a comment
dtolnay
left a comment
There was a problem hiding this comment.
Could you find out the specific std::io::ErrorKind or std::io::Error::raw_os_error that is being produced by the filesystem in this scenario? If it is something reasonably unique to this failure mode, I would prefer to ignore just that kind of error (without an environment variable).
3e8962c (Clean up dep-info files from OUT_DIR, 2024-10-22) made the cleanup step a fatal operation when cleanup fails. Some filesystems (e.g. NFS v3) can run into timing issues under load where .nfs* dummy files can still exist for a short window of time after the probe command completes. One way this can happen is when other processes, such as a malware scanner, holds the files open in the background for a short period of time. This window of time is just long enough for a failure to occur in remove_all(). Ignore DirectoryNotEmpty errors to account for this scenario.
Contributor
Author
|
I've updated this branch to specifically check for ErrorKind::DirectoryNotEmpty now. Thanks for reviewing. |
dtolnay
reviewed
Aug 11, 2025
| // that treat the entire OUT_DIR as an artifact. | ||
| if let Err(err) = fs::remove_dir_all(&out_subdir) { | ||
| if err.kind() != ErrorKind::NotFound { | ||
| if err.kind() != ErrorKind::NotFound && err.kind() != ErrorKind::DirectoryNotEmpty { |
Owner
There was a problem hiding this comment.
#512 adds an explanation comment and updates this to work with standard libraries that do not contain DirectoryNotEmpty.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3e8962c (Clean up dep-info files from OUT_DIR, 2024-10-22) made the cleanup step a fatal operation when cleanup fails. Some filesystems (e.g. NFS v3) can run into timing issues under load where .nfs* dummy files can still exist for a short window of time after the probe command completes. This window is just large enough for a failure to occur in remove_all().
Add an environment variable that allows users to make the cleanup operation non-fatal.