Skip to content

[MNT] fix and upgrade linting CI job#382

Merged
fkiraly merged 5 commits into
masterfrom
fix-lint
Jul 21, 2025
Merged

[MNT] fix and upgrade linting CI job#382
fkiraly merged 5 commits into
masterfrom
fix-lint

Conversation

@fkiraly

@fkiraly fkiraly commented Jul 16, 2025

Copy link
Copy Markdown
Collaborator

Fixes CI linting job by replacing the current job with a ruff based linting jobs. Linting rules are copied from sktime.

Linting checks are only applied to changed files.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Jul 16, 2025

@dswah dswah left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fkiraly there are a few references to sktime that i did not expect to see.
Are these necessary?

otherwise, ci.yml lgtm.

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
@fkiraly

fkiraly commented Jul 16, 2025

Copy link
Copy Markdown
Collaborator Author

@fkiraly there are a few references to sktime that i did not expect to see.
Are these necessary?

No, these are copy-paste accidents, most likely.

I often treat these horrendous yml files as "working black boxes", it is very non-obvious what settings need to be selected.

@dswah

dswah commented Jul 16, 2025

Copy link
Copy Markdown
Owner

I often treat these horrendous yml files as "working black boxes", it is very non-obvious what settings need to be selected.

😄 We just need to shake the box a little from time to time

@fkiraly fkiraly requested a review from dswah July 16, 2025 16:27
Comment thread .github/workflows/ci.yml
Comment thread pyproject.toml Outdated
@fkiraly fkiraly merged commit 6182d9b into master Jul 21, 2025
13 of 16 checks passed
@dswah dswah deleted the fix-lint branch December 2, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Continuous integration, unit testing & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants