[DOC] Fixed docstring of GAM classes - index of intercept estimate#324
Merged
Conversation
According to https://github.com/dswah/pyGAM/blob/master/pygam/pygam.py#L290, intercept will be added at the end of self.coef_
Wieser145
reviewed
Feb 6, 2023
Wieser145
left a comment
Wieser145
left a comment
There was a problem hiding this comment.
That's right, has anyone figured out why the calculated intercept is different then that of the mgcv package in R?
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 22 22
Lines 3208 3208
=======================================
Hits 3048 3048
Misses 160 160
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fkiraly
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to this code, intercept will be added at the end of self.coef_ (self.coef_[-1]) but not self.coef_[0]