Fix error with data ownership in cholesky#288
Merged
Conversation
Require that the fill-reducing permutation P of Cholesky factorizer owns its data before use. Fixes dswah#271
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #288 +/- ##
==========================================
+ Coverage 95.21% 95.25% +0.03%
==========================================
Files 22 22
Lines 3178 3223 +45
==========================================
+ Hits 3026 3070 +44
- Misses 152 153 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1tux
reviewed
Jul 5, 2021
1tux
left a comment
1tux
left a comment
There was a problem hiding this comment.
this is amazing and saved my life!
I have to say that this Cholesky thing doesn't even improve running time.
dswah
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require that the fill-reducing permutation P of Cholesky factorizer owns its data before use. Fixes #271
This sets the
OWNDATAflag of its data toTrue- in traceback it can be seen thatcol(line 102 ofscipy/sparse/_index.py), which is derived fromp, has this flag set to false. This creates a copy of the data if necessary (which apparently it wasn't in previous versions?)Someone should give this patch a shot on their machine as well.