Add gtx 5090 support #203
Merged
Add gtx 5090 support #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In k8s nvidia.com/gpu.product=NVIDIA-GeForce-RTX-5090 I think the matching logic needs to be adapted to avoid issues with this in the future? Perhaps there has already been some thinking regarding this.
Collaborator
|
We'll use canonical RTX5090 name and adjust the kubernetes matching logic to convert RTX-5090 to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In k8s nvidia.com/gpu.product=NVIDIA-GeForce-RTX-5090
I think the matching logic needs to be adapted to avoid issues with this in the future? Perhaps there has already been some thinking regarding this.