Clean up low- and high-level API clients #3355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
un-def
commented
Dec 8, 2025
un-def
commented
- Deprecate and ignore RunCollection.get_run_plan() repo_dir argument
- Ensure UsersAPIClient.get_my_user() returns UserWithCreds
- Ensure UserSSHKeyManager.get_user_key() returns user SSH key stored on the server
- Drop SSH key-related support code for pre-0.20.0 servers
* Deprecate and ignore RunCollection.get_run_plan() repo_dir argument * Ensure UsersAPIClient.get_my_user() returns UserWithCreds * Ensure UserSSHKeyManager.get_user_key() returns user SSH key stored on the server * Drop SSH key-related support code for pre-0.20.0 servers
jvstme
approved these changes
Dec 8, 2025
src/dstack/api/_public/runs.py
Outdated
| " automatically replicated to all clients.", | ||
| ) | ||
| ssh_key_pub = config_manager.dstack_key_path.with_suffix(".pub").read_text() | ||
| # Ensure we have a fresh key locally |
Contributor
There was a problem hiding this comment.
@un-def Sorry, just to confirm, why do we need the key locally when submitting a run? I thought we only need it when attaching to a run, no?
Collaborator
Author
There was a problem hiding this comment.
Right, both /get_plan and /apply endpoints generate the user key if missing, we don't need to trigger key generation manually. I've removed this redundant API call, added /get_plan/apply tests, and simplified server code a bit : 329e993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.