Consider backend offers when choosing optimal fleet #3101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3020
The PR updates the optimal fleet selection logic for the run. Previously, only pool (instance) offers were considered, and the fleet with the cheapest pool offer was chosen. Now, dstack also considers backend offers for all fleets and choses a fleet with the cheapest backend offer if there are no pool offers.
It's no longer necessary to specify
fleetsin run configuration to choose an elastic fleet without instances for the run – such fleet will be chosen if they have backend offers. Autocreated fleets can be created only in case when existing fleets have neither pool nor backend offers.The PR does NOT change run plan offers so that offers respect fleet specs – this is to be addressed in a separate PR.