Repository navigation
feat: filter Discover by current DSH host version - #486
Merged
Merged
Conversation
Only the generated bundle conflicted; sources merged cleanly. Rebuilt.
fkysly
approved these changes
Sep 3, 2026
fkysly
left a comment
Contributor
There was a problem hiding this comment.
收(CI 绿即合;合并冲突只有产物,已用合并后源码重建推回)。
对照 #473 里定的 v1 边界逐条核过,全部落对:
- 只标注 + 可选筛选,不默认过滤——
compatibleWithHost === true才生效,且只摘status === 'incompatible'(已声明且不满足);未声明、解析失败、元数据不可得、GitHub-only 一律可见。这是那 40% 推导盲区决定的正确保守面。 - 数据源用了 peer 推导(排除 cordis/schemastery、includePrerelease),把覆盖从 engines.dsh 的 2% 提到 ~60%——两个坑都避开了。
- 宿主读不到时不假装:unknown 状态下筛选不可启用,而不是空转。
- 卡片展示的是声明区间,事实不是结论,与 #401 那边的原则一致。
网络面也克制:日常浏览只取当前页 24 条的元数据,全量补齐只在用户显式开筛选时发生,8 并发封顶 + 24h 缓存(单文件、0600、无路径拼接面)。目录 schema 一字未动——顺序对了:推导先跑通,数据质量看清,再谈固化进目录。
1195 passed(合并后)。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #473
Summary
engines.dshplus lockstep@deepseek-ai/dsh*peers, excluding Cordis and schemasterydshHostInfo()path; an unlocatable host is reported as unknown and cannot enable a pretend filterMetadata path
This PR deliberately does not change the public catalog schema. It implements the fallback discussed in the issue:
.dsh-marketstate directoryunknownresults, with a short outage circuit breaker; they are never persisted as "undeclared" and never hide a pluginversion,engines.dsh, and@deepseek-ai/*peer ranges are cached; compatibility conclusions are recomputed against the current hostThat lets the peer-derived path run and expose its data quality before any inference is made part of the directory's contract.
Verification
npm test— 56 files, 1195 tests passednpm run check— typecheck, build, client bundle rebuild, restart smoke passednpm run test:compat— 11/11 passednpm pack --dry-run --json— 148 files, preflight passedgit diff --check— passednpm run test:web— authenticated browser-capture guard passed; the 29 browser cases could not launch locally because the existing dsh/pnpm 9 scaffold install failed before loading this bundle (the GitHub CI matrix remains authoritative for those cases)