Repository navigation
assert_trace does not work correctly with functions that use the same decorator #876
Description
Bug report
What's wrong
Our assert_trace from pytest plugin doesn't work correctly when two or more different functions are using the same decorator, it not considers that those functions are different! See the example below:
def test_two_functios_using_same_decorator(returns: ReturnsAsserts):
def decorator(func):
def decorated(*args, **kwargs):
return func(*args, **kwargs)
return decorated
@decorator
def func_one():
return Success(42)
@decorator
def func_two():
return Success(42)
with returns.assert_trace(Success, func_one):
func_two()That test should fail because we want to assert the Success creation inside func_one, but I'm calling func_two and the test is passing!
How is that should be
Our pytest plugin should consider that those functions are different!
System information
pythonversion: 3.9returnsversion: 0.16.0
Activity
sobolevn commentedon Mar 27, 2021
What if we use
@wrapsondef decorated? 🤔thepabloaguilar commentedon Mar 27, 2021
Also doesn't work, I tested with
safetoo (safe uses wraps)wrapsjust keep some metadata like name and docstring. But if we get the code from them they are the samethepabloaguilar commentedon Nov 3, 2022
I know how to solve this issue! Reading the Python docs I discovered that wrapped functions has the
__wrapped__attribute which we can use to get the "original" function!The users just need to pay attention to use the
wrapsdecorator inside their decorators!Docs: https://docs.python.org/3/library/functools.html#functools.update_wrapper
sobolevn commentedon Nov 3, 2022
Let's add this to the docs :)
thepabloaguilar commentedon Nov 10, 2022
I made the fix and broke other part 😆
The thing is, fixing this (with the actual code ive made) we won't be able to handle creations within decorators cause we're getting the most inner function,
@safewon't work for example:Failureis being created insidesafeand not_safe_decorated_functionSuggestions?
sobolevn commentedon Nov 10, 2022
No :(
Fix assert_trace matching other functions with the same decorator (#2552