Add a button that opens a one-time login link#212
Merged
Conversation
Collaborator
|
Maybe we should just change it to 'Log in' that way it's less confusing that it's just logging you in! |
Collaborator
Author
|
Sure, we can do that. The "access denied" thing is super effing annoying, even then, but not something we can fix from here. Presumably, a login button should have a different icon than the pencil? |
Collaborator
|
True, let's use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #211.
But I have bad news -- this runs into the infuriating core bug where, if you're already logged in and you use this button, you get shot over to an "access denied" page. Because you're logged in, get it?
Drupal can be so goddamned infuriating sometimes. This is something we could shim around in Drupal CMS Helper, assuming there exists a core issue to correct this annoyance.
Also kind of annoying is that, if you're not logged in, this redirects you to the user edit form, so you can change your password. We could alter that redirect if we were so inclined (for this specific button only), but where should it redirect to?
AI Disclosure
Nope, wrote this with my human brain.