Skip the installer's database set-up screen by pre-generating the database settings and hash salt#210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The installer looks for three things in settings.php to consider the database settings ready, and Drupal ready to be installed: the hash salt,
$databases, and the config sync directory.We can set up all of these things in
settings.local.php, allowing the installer to skip database setup. The hash salt can be uniquely generated at install time by Node'scrypto.randomBytes, much the way Drupal itself works.This will mean that the database is not portable, but that's frankly already the case. The launcher is betting on the future state of being able to move a Drupal site from one host to another by archiving composer.json/lock, config, and content, not syncing databases.
AI Disclosure
Wrote all of this myself!