After installing, store a setting that forbids the use of pre-built archives#205
Merged
Conversation
phenaproxima
force-pushed
the
no-archive
branch
from
5e4c8f4 to
58d572f
Compare
phenaproxima
force-pushed
the
no-archive
branch
from
96ea360 to
d921ca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is another attempt to fix #203, after it broke everyone in v1.0.6 and was subsequently reverted in v1.0.7.
I think what we've learned (the hard way) is that the application itself, and its internal resources, can never be treated as writable, full stop. Any permanent state change (like "never use a pre-built archive") needs to be stored in the app's user data directory.
So this uses the
electron-storelibrary to easily get and set that state information. It also adds a test which proves that using the archive once means it will never be used again.AI Disclosure
No AI was used here.