fix: Allow access log to log paths jetty rejects#9788
Closed
Mahoney wants to merge 1 commit intodropwizard:release/5.0.xfrom
Closed
fix: Allow access log to log paths jetty rejects#9788Mahoney wants to merge 1 commit intodropwizard:release/5.0.xfrom
Mahoney wants to merge 1 commit intodropwizard:release/5.0.xfrom
Conversation
Contributor
Author
|
To state the obvious I have failed to add a test that actually demonstrates this works... just putting this here as a tentative direction of travel rather than asking for it to be merged. If someone can point me at an appropriate way to write an integration test proving this works that would be awesome. |
Tentative fix for dropwizard#9773 The test change proves that logback-access's `ResponseWrapper` is not brilliant. Should probably be fixed in logback-access, but could be fixed
Mahoney
force-pushed
the
access-request-logging-bad-path
branch
from
d9d0c18 to
559b38a
Compare
Contributor
Author
Contributor
Author
|
I think if we can get qos-ch/logback-access#23 merged and released then this PR would become relevant again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tentative fix for #9773
Problem:
When running with access request logging (via logback-access), a request such as this:
GET /..;/manager/htmlresults in no access request log entry and a stacktrace in the logs.
See #9773
Solution:
Use
ch.qos.logback.access:logback-access-jetty12's provided ways of adapting Jetty classes to the Servlet API to allow using logbakc access.