Logback request log: combine headers#8008
Merged
joschi merged 1 commit intodropwizard:release/4.0.xfrom Dec 10, 2023
Merged
Conversation
Mahoney
added a commit
to Mahoney-forks/logback-access
that referenced
this pull request
Jan 16, 2025
Pushes the fixes in dropwizard/dropwizard#8008 upstream into logback-access, where they probably should be. Unfortunately `HttpGetUtil` uses `HttpURLConnection`, which makes it hard to write a test for this because `HttpURLConnection` combines the headers for you.
Mahoney
added a commit
to Mahoney-forks/logback-access
that referenced
this pull request
Jan 16, 2025
Pushes the fixes in dropwizard/dropwizard#8008 upstream into logback-access, where they probably should be. Unfortunately `HttpGetUtil` uses `HttpURLConnection`, which makes it hard to write a test for this because `HttpURLConnection` combines the headers for you. Signed-off-by: Robert Elliot <[email protected]>
ceki
pushed a commit
to qos-ch/logback-access
that referenced
this pull request
Jul 18, 2025
Pushes the fixes in dropwizard/dropwizard#8008 upstream into logback-access, where they probably should be. Unfortunately `HttpGetUtil` uses `HttpURLConnection`, which makes it hard to write a test for this because `HttpURLConnection` combines the headers for you. Signed-off-by: Robert Elliot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #7965
This PR ports the
DropwizardJettyServerAdapterto therelease/4.0.xbranch. This allows logging all response headers instead of only the last header value.