Address some errorprone warnings in the tests#10509
Merged
joschi merged 17 commits intodropwizard:release/4.0.xfrom Oct 5, 2025
Merged
Address some errorprone warnings in the tests#10509joschi merged 17 commits intodropwizard:release/4.0.xfrom
joschi merged 17 commits intodropwizard:release/4.0.xfrom
Conversation
…nValidationExceptionTest
joschi
approved these changes
Oct 5, 2025
joschi
pushed a commit
that referenced
this pull request
Oct 5, 2025
* Update to use non-deprecated mockito strictness configuration method * Throwable#getCause is synchronized and should remain so when overridden * Replace deprecated UsernamePasswordCredentials#getPassword with getUserPassword * Remove usage of deprecated IntParam from dropwizard-testing tests * Suppress some errorprone warnings in dropwizard-core tests * Simplify dropwizard-db TimeBoundHealthCheckTest * Replace deprecated Session#createNativeQuery in TransactionHandlingTest * Simplify LoggingJdbiExceptionMapperTest * Avoid unnecessary autoboxing in ServerLifecycleListenerTest * Remove unused mock from DropwizardSlf4jRequestLogWriterTest * Make fields final in SlowRequestFilterTest * Suppress warning about confusing nullness annotations in ConfigurationValidationExceptionTest * Add @OverRide annotation in HealthCheckConfigValidatorTest * Use logback ListAppender instead of mocking in HealthCheckConfigValidatorTest * Avoid calling mocked methods in ScheduledHealthCheckTest * Avoid deprecated assert-j method in JsonHealthResponseProviderTest * Assert the state of Futures in TcpHealthCheckTest Refs #10509
joschi
pushed a commit
that referenced
this pull request
Oct 5, 2025
* Update to use non-deprecated mockito strictness configuration method * Throwable#getCause is synchronized and should remain so when overridden * Replace deprecated UsernamePasswordCredentials#getPassword with getUserPassword * Remove usage of deprecated IntParam from dropwizard-testing tests * Suppress some errorprone warnings in dropwizard-core tests * Simplify dropwizard-db TimeBoundHealthCheckTest * Replace deprecated Session#createNativeQuery in TransactionHandlingTest * Simplify LoggingJdbiExceptionMapperTest * Avoid unnecessary autoboxing in ServerLifecycleListenerTest * Remove unused mock from DropwizardSlf4jRequestLogWriterTest * Make fields final in SlowRequestFilterTest * Suppress warning about confusing nullness annotations in ConfigurationValidationExceptionTest * Add @OverRide annotation in HealthCheckConfigValidatorTest * Use logback ListAppender instead of mocking in HealthCheckConfigValidatorTest * Avoid calling mocked methods in ScheduledHealthCheckTest * Avoid deprecated assert-j method in JsonHealthResponseProviderTest * Assert the state of Futures in TcpHealthCheckTest Refs #10509
joschi
added a commit
that referenced
this pull request
Oct 5, 2025
* Update to use non-deprecated mockito strictness configuration method * Throwable#getCause is synchronized and should remain so when overridden * Replace deprecated UsernamePasswordCredentials#getPassword with getUserPassword * Remove usage of deprecated IntParam from dropwizard-testing tests * Suppress some errorprone warnings in dropwizard-core tests * Simplify dropwizard-db TimeBoundHealthCheckTest * Replace deprecated Session#createNativeQuery in TransactionHandlingTest * Simplify LoggingJdbiExceptionMapperTest * Avoid unnecessary autoboxing in ServerLifecycleListenerTest * Remove unused mock from DropwizardSlf4jRequestLogWriterTest * Make fields final in SlowRequestFilterTest * Suppress warning about confusing nullness annotations in ConfigurationValidationExceptionTest * Add @OverRide annotation in HealthCheckConfigValidatorTest * Use logback ListAppender instead of mocking in HealthCheckConfigValidatorTest * Avoid calling mocked methods in ScheduledHealthCheckTest * Avoid deprecated assert-j method in JsonHealthResponseProviderTest * Assert the state of Futures in TcpHealthCheckTest Refs #10509 Co-authored-by: Russell Howe <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address various errorprone warnings in tests
TcpHealthCheckTestJsonHealthResponseProviderTestScheduledHealthCheckTestListAppenderinstead of mocking inHealthCheckConfigValidatorTest@Overrideannotation inHealthCheckConfigValidatorTestConfigurationValidationExceptionTestSlowRequestFilterTestDropwizardSlf4jRequestLogWriterTestServerLifecycleListenerTestLoggingJdbiExceptionMapperTestSession#createNativeQueryinTransactionHandlingTestTimeBoundHealthCheckTestIntParamfrom dropwizard-testing testsUsernamePasswordCredentials#getPasswordwithgetUserPasswordThrowable#getCauseis synchronized and should remain so when overridden