Skip Http2WithConscryptTest on ARM MacOS#10371
Merged
joschi merged 2 commits intorelease/5.0.xfrom Aug 19, 2025
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem:
When run on an ARM MacOS machine, I'm always getting:
I believe this is due to google/conscrypt#1034 - lack of an ARM native build for MacOS for the Conscrypt library.
Solution:
Skip the affected tests when running on ARM MacOS (
aarch64), so that build does not fail.It's never a particularly satisfying thing to have to skip tests, but I think it's probably the simplest/clearest way to unblock contributions from developers on ARM Macs. Please do say if there's a better approach that you'd prefer, though.
Refs #10284