RFR: Change Logback request log implementation#10210
Draft
zUniQueX wants to merge 1 commit intodropwizard:release/5.0.xfrom
Draft
RFR: Change Logback request log implementation#10210zUniQueX wants to merge 1 commit intodropwizard:release/5.0.xfrom
zUniQueX wants to merge 1 commit intodropwizard:release/5.0.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace logback's
RequestLogImplwith a custom implementation.Motivation
Logback's request logging was broken for a long time. Now, the
IAccessEventand request log implementations were updated, but use an (incomplete) wrapper implementation without servlet classes. In general, Logback has a slow update cycle.If a user wants to extend or customize the request log implementation, the non-implemented methods will cause problems. Or if a new Jetty version is released, we'd have to wait until logback updates the request log implementation.
Solution
For now, we can extend the
IAccessEventwith a custom implementation and provide the request log ourselves. This doesn't break dependent functions like JSON logging etc. For Dropwizard 6, we can re-evaluate, if we'd want to completely remove the logback-access-* components.