Configuration cache pt1#57
Closed
qwert2603 wants to merge 5 commits into
Closed
Conversation
Merged
qwert2603
force-pushed
the
configuration-cache-pt1
branch
from
October 10, 2022 18:50
2856e81 to
b8948e2
Compare
…sk's configurationAction
qwert2603
force-pushed
the
configuration-cache-pt1
branch
from
October 11, 2022 05:03
b8948e2 to
bd2ecc0
Compare
Contributor
Author
|
@handstandsam Hi! Will this PR be helpful to simplify review? |
Collaborator
|
Closing since #51 was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the part 1 (first 5 commits) of #51 to simplify reviewing and merging.
projectproperty during task's execution (@TaskAction) breaks configuration cache. That's whyproject.pathis now saved while configuring the task inDependencyGuardTreeDiffer.ConfigurationValidatorsare now called in tasks's configurationAction instead of@TaskActionto avoid breaking configuration cache (these validations useprojectproperty).Like in original PR, changes are split to commits to simplify review.