Repository navigation
fix(constellation): start Sagittarius on Nov 23 - #391
Merged
gouguoyin merged 1 commit intoNov 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsSagittariusis true on November 22, the last day of Scorpio:The table at the top of
constellation.gohas Scorpio as 10/24 to 11/22 and Sagittarius as 11/23 to 12/21, andIsScorpioalready usesday <= 22. So on 22 NovemberIsScorpioandIsSagittariusare both true, whileConstellation()returns Scorpio. The existing Scorpio test already asserts that2020-11-22is Scorpio.This changes the comparison to
day >= 23and addss.False(Parse("2020-11-22").IsSagittarius())to the existingvalid carboncase.I couldn't run Go locally, so I ran the suite on a fork:
constellation_unit_test.go:351(TestConstellationSuite/TestCarbon_IsSagittarius/valid_carbon). The ubuntu and windows jobs of that run were cancelled after the macOS failure, so they didn't report a result.The commit in this PR is the squashed form of the fix branch (identical tree).