-
Notifications
You must be signed in to change notification settings - Fork 101
[Feature/#409] Retrofit -> Ktor 마이그레이션 (core:network 구현) #479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/#409] Retrofit -> Ktor 마이그레이션 (core:network 구현) #479
Conversation
...twork-api/src/commonMain/kotlin/com/droidknights/app/core/network/api/DroidknightsNetwork.kt
Outdated
Show resolved
Hide resolved
core/model/model-session/src/commonMain/kotlin/com/droidknights/app/core/model/session/Room.kt
Outdated
Show resolved
Hide resolved
...session/src/commonMain/kotlin/com/droidknights/app/core/data/session/mapper/SessionMapper.kt
Outdated
Show resolved
Hide resolved
...ession/src/commonMain/kotlin/com/droidknights/app/core/data/session/model/SessionResponse.kt
Outdated
Show resolved
Hide resolved
.../network/network/src/commonMain/kotlin/com/droidknights/app/core/network/di/NetworkModule.kt
Outdated
Show resolved
Hide resolved
6497f63 to
ad562ec
Compare
|
코드리뷰 달아주신 내용을 토대로 수정하여 PR 올렸습니다! 확인부탁드려요:) |
taehwandev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다.
976db7f to
da8898b
Compare
|
안녕하세요! |
.../network/network/src/commonMain/kotlin/com/droidknights/app/core/network/di/NetworkModule.kt
Outdated
Show resolved
Hide resolved
...twork-api/src/commonMain/kotlin/com/droidknights/app/core/network/api/DroidKnightsNetwork.kt
Outdated
Show resolved
Hide resolved
...ession/src/commonMain/kotlin/com/droidknights/app/core/data/session/model/SessionResponse.kt
Outdated
Show resolved
Hide resolved
...data/data-session/src/commonMain/kotlin/com/droidknights/app/core/data/session/SessionApi.kt
Outdated
Show resolved
Hide resolved
3830e51 to
930e05b
Compare
workspace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leeeyubin 긴 티키타카 속에 approve를 드리게 되어 기쁩니다 ㅎㅎ CI 터지는건 제가 좀 살펴볼게요! 쉽게 고칠 수 있는거면 추가로 comment 남겨드리고, 아니면 머지 후 고치도록 하겠습니다.
수고하셨습니다 👍 💯
|
@leeeyubin InsertKoinIO/koin#2029 이 이슈랑 같은 이슈로 보이는데요,
사실 요 pr 뒤로 할 작업들이 좀 밀려있어서, 제가 퀵하게 수정해보겠습니다. 수고하셨습니다!! |
397c8b8
into
droidknights:2025/compose-multiplatform
|
위 pr에서
체크 다 돌면 일단 머지할 예정인데요, 다른 의견이 있으시다면 pr에 댓글 남겨주세요 ㅎㅎ |
|
넵! 바뀐 부분 PR로 확인했습니다! |
Issue
Overview (Required)
SessionApi가 있는 모듈로 전이되지 않도록,DroidKnightsNetwork라는 추상화 계층을 도입하고 get 함수를 정의해 분리해두었습니다HttpResponse.body()의 동작 방식인 typeInfo를 활용하였습니다.HttpClientEngine을 사용하였습니다.coreNetworkModule모듈을 생성하여 network 코드 관련 의존성을 주입해 주었습니다.Screenshot