Fix ClassCastException when parsing Apple metadata of unexpected type #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent a ClassCastException
Owner
|
Thank you for your contribution. Please undo the formatting changes so that we can more easily see what you have actually changed here. |
Owner
|
Also if you're able to share an image that reproduces this problem, it would be helpful. |
added 2 commits
September 13, 2022 13:19
…will prevent a ClassCastException" This reverts commit 621b1fe.
…vent a ClassCastException
Contributor
Author
Sorry, that was automatically done by my IDE. It should be better after the last commit |
Contributor
Author
Unfortunately I cannot share the images we have due to legal issues. |
drewnoakes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the Apple metadata is stored as a String. This fix will prevent a ClassCastException
We have found a few images where the JPG contained metadata as String instead of Bytes/Longs:. These images were created using an iPhone 7 or 8 with an unknown iOS version.
Examples of the metadata as String:
bplist00��������UflagsUvalueUepochYtimescaleQ1]3448599201458Q0Z1000000000����#-/=?
and
bplist00��������UflagsUvalueUepochYtimescaleQ1]3408834508875Q0Z1000000000����#-/=?