Skip to content

GH-40968: [C++][Gandiva] add RE2::Options set_dot_nl(true) for Like f#80

Merged
xxlaykxx merged 2 commits intodremio:dremio_25.0_12.0from
xxlaykxx:25.0_12.0
Jul 12, 2024
Merged

GH-40968: [C++][Gandiva] add RE2::Options set_dot_nl(true) for Like f#80
xxlaykxx merged 2 commits intodremio:dremio_25.0_12.0from
xxlaykxx:25.0_12.0

Conversation

@xxlaykxx
Copy link

…unction.

cherry-pick

xxlaykxx and others added 2 commits July 11, 2024 07:47
…Like function (apache#40970) (#68)

Gandiva function "LIKE" does not always work correctly when the string contains \n.
String value:
`[function_name: "Space1.protect"\nargs: "passenger_count"\ncolumn_name: "passenger_count" ]`
Pattern '%Space1%' nor '%Space1.%' do not match.

added flag set_dot_nl(true) to LikeHolder

add unit tests.

Yes

**This PR includes breaking changes to public APIs.**

* GitHub Issue: apache#40968

Lead-authored-by: Ivan Chesnov <[email protected]>

Signed-off-by: Sutou Kouhei <[email protected]>
…at have been deprecated (apache#43121)

Jobs are failing to find mirrorlist.centos.org

Updating repos based on solution from: apache#43119 (comment)

Via archery

No
* GitHub Issue: apache#43119

Lead-authored-by: Raúl Cumplido <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Raúl Cumplido <[email protected]>
@github-actions
Copy link

❌ GitHub issue apache#40968 could not be retrieved.

@xxlaykxx xxlaykxx marked this pull request as ready for review July 12, 2024 04:29
@xxlaykxx xxlaykxx merged commit 0890149 into dremio:dremio_25.0_12.0 Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants