DX-67361 Added subsr/substring function with int32 signuture.#26
Closed
xxlaykxx wants to merge 1 commit intodremio:dremio-12.0-mainfrom
xxlaykxx:DX-67361
Closed
DX-67361 Added subsr/substring function with int32 signuture.#26xxlaykxx wants to merge 1 commit intodremio:dremio-12.0-mainfrom xxlaykxx:DX-67361
xxlaykxx wants to merge 1 commit intodremio:dremio-12.0-mainfrom
xxlaykxx:DX-67361
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
github-actions
bot
added
Component: C++
Component: C++ - Gandiva
awaiting review
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dremio signature for substring/substr java function was changed in scope https://gerrit.drem.io/gerrit/c/dremio/+/51411 (ecause unnecessary casting from BigInt to Int). After this changes start use java function instead of gandiva and we have 2 sec regression.
After investigation of gandiva impl for this function, I found that here casting from int64 to int32 also present - so for consistency with java, signature for this function was also changed to int32. And Dremio will back to use this function again.