Fix invert system icons when using software rendering#701
Merged
dremin merged 1 commit intodremin:masterfrom Oct 15, 2023
Merged
Fix invert system icons when using software rendering#701dremin merged 1 commit intodremin:masterfrom
dremin merged 1 commit intodremin:masterfrom
Conversation
xoascf
commented
Oct 15, 2023
Comment on lines
+13
to
+15
| float3 notAlpha = color.rgb * (1.0 / max(0.0001, alpha)); | ||
| notAlpha = 1 - notAlpha; | ||
| color.rgb = notAlpha * alpha; |
Collaborator
Author
There was a problem hiding this comment.
Without using notAlpha it gives exactly the same result, since the generated shader only preserves the logic, so I didn't bother to change it to how it was before but being more explicit, this was before for PS 2.0:
color.rgb = color.rgb * (1.0 / max(0.0001, alpha));
color.rgb = 1 - color.rgb;
color.rgb *= alpha;
dremin
approved these changes
Oct 15, 2023
Owner
dremin
left a comment
dremin
left a comment
There was a problem hiding this comment.
This looks great! I had attempted to use PS 2.0 originally but didn't adjust the shader code properly. Thanks!
dremin
added a commit
to cairoshell/cairoshell
that referenced
this pull request
Feb 22, 2024
dremin
added a commit
to cairoshell/cairoshell
that referenced
this pull request
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downgrades the
shader_invert.psshader version from 3.0 to 2.0, which is required for software rendering (Rendering Tier 0).Closes #700