Repository navigation
fix(sheets-formula-ui): reposition help card as formula text grows - #7744
Merged
Merged
Conversation
reitpaul6-crypto
approved these changes
Sep 25, 2026
gonzalezangeldavi04-max
approved these changes
Sep 25, 2026
The help card only recalculated its position when the function info or the active parameter index changed. Typing inside a single argument changes neither, so when the cell editor wrapped onto another line the card kept its old top and covered the text being typed. Recompute the position whenever the formula text changes, as SearchFunction already does with its search text. close dream-num#7699
wpxp123456
force-pushed
the
claude/7699-fix
branch
from
September 28, 2026 11:42
27cc52d to
399a1e7
Compare
wpxp123456
force-pushed
the
claude/7699-fix
branch
from
September 28, 2026 12:22
56924df to
068bfb2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #7744 +/- ##
========================================
Coverage 81.08% 81.08%
========================================
Files 3059 3059
Lines 198216 198216
Branches 51296 50967 -329
========================================
+ Hits 160718 160722 +4
+ Misses 37438 37434 -4
Partials 60 60 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #7699
The formula help card's position only recomputed when the active function or parameter index changed, not when the formula text itself changed. So typing a long formula that wraps onto extra lines grew the editor without moving the help card, and the card stayed put and covered the wrapped text. The fix adds
formulaTextto theuseEditorPositiondependency list so the card repositions as the editor grows, and a test covers the card moving down when a formula wraps from one line to three.Pull Request Checklist